LayoutTests/virtual/threaded/animations/composited-animations-rotate-scale.html - Issue 1270303002: Composited Animations: Introduce pixel-ref layout tests.

Side by Side Diff: LayoutTests/virtual/threaded/animations/composited-animations-rotate-scale.html

Issue 1270303002: Composited Animations: Introduce pixel-ref layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@disable

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/animations/resources/composited-animations-data/rotate-scale.js ('K') | « LayoutTests/animations/resources/composited-animations-data/timing-function.js ('k') | LayoutTests/virtual/threaded/animations/composited-animations-rotate-scale-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../../../animations/resources/composited-animation-test.js"></scrip t>

	5 <script src="../../../animations/resources/composited-animations-data/rotate-sca le.js"></script>

	6 <script>

	7 var test = new CompositedAnimationTest(false);
	Ian Vollick 2015/08/05 13:58:46 boolean parameter is super-confusing, especially s boolean parameter is super-confusing, especially since true == disabled. Can you please find some way to make this named (even if you just set a local variable to the boolean value)? Also, if the compositor animations are disabled via InternalSettings (this is my preference), you could leave the settings stuff to the wrapping html files, and just construct a CompositedAnimationTest with no parameters. dstockwell 2015/08/06 00:23:19 +1 on the boolean param We also seem to always ca Show quoted text On 2015/08/05 at 13:58:46, vollick wrote: > boolean parameter is super-confusing, especially since true == disabled. Can you please find some way to make this named (even if you just set a local variable to the boolean value)? Also, if the compositor animations are disabled via InternalSettings (this is my preference), you could leave the settings stuff to the wrapping html files, and just construct a CompositedAnimationTest with no parameters. +1 on the boolean param We also seem to always call these three functions, you could just define: runComposited(data) and runNonComposited(data) loyso (OOO) 2015/08/06 07:03:33 Sure, I'll make it named. CompositedAnimationTest Show quoted text On 2015/08/05 13:58:46, vollick wrote: > boolean parameter is super-confusing, especially since true == disabled. Can you > please find some way to make this named (even if you just set a local variable > to the boolean value)? Also, if the compositor animations are disabled via > InternalSettings (this is my preference), you could leave the settings stuff to > the wrapping html files, and just construct a CompositedAnimationTest with no > parameters. Sure, I'll make it named. CompositedAnimationTest not only passes it to Internals.disableThreadedAnimation but also checks, whether produced animations are run on compositor in fact. See that assertRunningThread method. loyso (OOO) 2015/09/14 06:19:07 Done. Show quoted text On 2015/08/05 13:58:46, vollick wrote: > boolean parameter is super-confusing, especially since true == disabled. Can you > please find some way to make this named (even if you just set a local variable > to the boolean value)? Also, if the compositor animations are disabled via > InternalSettings (this is my preference), you could leave the settings stuff to > the wrapping html files, and just construct a CompositedAnimationTest with no > parameters. Done.
	8 test.registerTestsData(rotateScaleTests);

	9 test.run();

	10 </script>

	11 </body>

	12 </html>

OLD	NEW