Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 | |
| 2 var animateRotate = { | |
| 3 keyframes: [ | |
| 4 {rotate: '-10deg'}, | |
| 5 {rotate: '470deg'} | |
| 6 ], | |
| 7 color: 'maroon', | |
| 8 margin: 5, | |
| 9 stamps: [ | |
|
dstockwell
2015/08/06 00:23:19
Why isn't this just an array of numbers?
`stamps`
loyso (OOO)
2015/09/14 06:19:07
I want to keep it extensible so we can add extra p
| |
| 10 {at: 0}, | |
| 11 {at: 0.05}, | |
| 12 {at: 0.15}, | |
| 13 {at: 0.25}, | |
| 14 {at: 0.35}, | |
| 15 {at: 0.45}, | |
| 16 {at: 0.5}, | |
| 17 {at: 0.55}, | |
| 18 {at: 0.65}, | |
| 19 {at: 0.75}, | |
| 20 {at: 0.85}, | |
| 21 {at: 0.95}, | |
| 22 {at: 1.05}, | |
| 23 {at: 1.15}, | |
| 24 ] | |
| 25 }; | |
| 26 | |
| 27 var animateScale = { | |
| 28 keyframes: [ | |
| 29 {scale: '0.1'}, | |
| 30 {scale: '1'} | |
| 31 ], | |
| 32 color: 'peru', | |
| 33 margin: 5, | |
| 34 marker: false, // TODO(loyso): This mustn't affect cc/blink consistency. | |
|
Ian Vollick
2015/08/05 13:58:46
What do you mean by this TODO?
loyso (OOO)
2015/09/14 06:19:07
Done.
| |
| 35 stamps: [ | |
|
Ian Vollick
2015/08/05 13:58:46
Just to make sure I'm understanding how your test
loyso (OOO)
2015/08/06 06:44:18
Yes, that's correct. See the comments in composite
| |
| 36 {at: 0}, | |
| 37 {at: 0.05}, | |
| 38 {at: 0.15}, | |
| 39 {at: 0.25}, | |
| 40 {at: 0.35}, | |
| 41 {at: 0.45}, | |
| 42 {at: 0.5}, | |
| 43 {at: 0.55}, | |
| 44 {at: 0.65}, | |
| 45 {at: 0.75}, | |
| 46 {at: 0.85}, | |
| 47 {at: 0.95}, | |
| 48 {at: 1.05}, | |
| 49 {at: 1.15}, | |
| 50 ] | |
| 51 }; | |
| 52 | |
| 53 var rotateScaleTests = [animateRotate, animateScale]; | |
| 54 | |
| OLD | NEW |