webkit/fileapi/local_file_util.cc - Issue 12703012: Have media gallery (through native media file util) use MIME sniffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/local_file_util.cc

Issue 12703012: Have media gallery (through native media file util) use MIME sniffer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Previous code review response, plus trying to get new unit test passing. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/fileapi/local_file_util.cc

diff --git a/webkit/fileapi/local_file_util.cc b/webkit/fileapi/local_file_util.cc

index 57454ebb426da21d6bb96eeb58f8ef0c76243e7f..b7b9382084d452c8b2a323ab9c4b8c95d373dea9 100644

--- a/webkit/fileapi/local_file_util.cc

+++ b/webkit/fileapi/local_file_util.cc

@@ -13,6 +13,7 @@

#include "webkit/fileapi/file_system_url.h"

#include "webkit/fileapi/file_system_util.h"

#include "webkit/fileapi/native_file_util.h"

+#include <fstream>

namespace fileapi {

@@ -250,6 +251,9 @@ base::PlatformFileError LocalFileUtil::CreateSnapshotFile(

base::PlatformFileInfo* file_info,

base::FilePath* platform_path,

SnapshotFilePolicy* policy) {

+ LOG(WARNING) << "LocalFileUtil::CreateSnapshotFile";

+ std::ofstream mylog("/tmp/krblog", std::ios::app);

+ mylog << "LocalFileUtil::CreateSnapshotFile" << std::endl;;

DCHECK(policy);

DCHECK(file_info);

// We're just returning the local file information.