Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 12703008: Cut data point upload batch size to 25. (Closed)

Created:
7 years, 9 months ago by benchen
Modified:
7 years, 9 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, skiabot_google.com
Visibility:
Public.

Description

Cut data point upload batch size to 25. Some bots have lower speed sending http data out, and this will make it less likely to timeout. Did not try 50 because once we switch to using Chrome dashboard app, extra work needs to be done for each data point which will take longer. Since appengine has the fixed 30s timeout policy, there's not too much we can do unless we convince Chrome to switch to other solutions. Current Skia data on our app instance: https://skiadash.appspot.com/report Committed: https://code.google.com/p/skia/source/detail?r=8133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bench/bench_graph_svg.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
benchen
First try on batch size adjustment. Already temporarily changed the app side to prevent some ...
7 years, 9 months ago (2013-03-13 17:12:23 UTC) #1
borenet
7 years, 9 months ago (2013-03-13 18:26:23 UTC) #2
On 2013/03/13 17:12:23, benchen wrote:
> First try on batch size adjustment. Already temporarily changed the app side
to
> prevent some other potential problems.

LGTM.  This is still disabled on the bots.  Once things start to cycle green,
I'll enable on one platform at a time to make sure this helps.

Powered by Google App Engine
This is Rietveld 408576698