Issue 1270293002: Merge to XFA: Don't dispose the isolate if its provided by the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1270293002: Merge to XFA: Don't dispose the isolate if its provided by the embedder (Closed)

Created:
5 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Don't dispose the isolate if its provided by the embedder (cherry picked from commit 7ea305f1bd4efc1838fba053e4399358d6765ec7) Original Review URL: https://codereview.chromium.org/1269783005 . BUG=chromium:515718 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/29007840b6deb699174ae5a6ef6b1188d001aa05

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	fpdfsdk/include/javascript/JS_Runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	fpdfsdk/src/javascript/JS_Runtime.cpp	View		3 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

Committed patchset #1 (id:1) manually as 29007840b6deb699174ae5a6ef6b1188d001aa05 (presubmit successful).

5 years, 4 months ago (2015-08-05 07:02:16 UTC) #2

Message was sent while issue was closed.

lgtm