Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 12702024: Fix warnings-as-errors in Android third-party libs (Closed)

Created:
7 years, 9 months ago by borenet
Modified:
7 years, 9 months ago
Reviewers:
bsalomon, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix warnings-as-errors in Android third-party libs Committed: https://code.google.com/p/skia/source/detail?r=8329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M gyp/dependencies.gypi View 5 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
borenet
Addresses failures from https://codereview.chromium.org/12963002/
7 years, 9 months ago (2013-03-22 12:07:39 UTC) #1
djsollen
lgtm
7 years, 9 months ago (2013-03-22 12:17:37 UTC) #2
bsalomon
lgtm
7 years, 9 months ago (2013-03-22 13:10:20 UTC) #3
borenet
7 years, 9 months ago (2013-03-22 13:16:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r8329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698