Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 12702012: MIPS: Implement many KeyedStoreStubs using Crankshaft (Closed)

Created:
7 years, 9 months ago by palfia
Modified:
7 years, 9 months ago
Reviewers:
kisg, Paul Lind, kilvadyb, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Implement many KeyedStoreStubs using Crankshaft Port r14001 (28443693) Original commit message: - Addition of a compiled hydrogen stub for KeyedStores. - Inlining of "grow" stubs into OPTIMIZED_FUNCTIONs - Addition of new "ignore OOB" ic stub that silently swallows out-of-bounds stores to external typed arrays. - Addition of new "copy-on-write" ic stub that inlines allocation and copying operations for cow array - New stub are generated with Crankshaft, so they are automatically inlined into OPTIMIZED_FUNCTIONs BUG= Committed: https://code.google.com/p/v8/source/detail?r=14018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 9 months ago (2013-03-20 21:01:55 UTC) #1
Paul Lind
lgtm
7 years, 9 months ago (2013-03-20 21:30:38 UTC) #2
palfia
7 years, 9 months ago (2013-03-20 21:43:41 UTC) #3
Message was sent while issue was closed.
Committed manually as r14018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698