Pepper: Unify Buffer and BufferTrusted APIs.

Pepper: Unify Buffer and BufferTrusted APIs.

For consistency, APIs with both normal/trusted and normal/private interfaces
will be merged together. This also makes it easer to generate thunks for
more IDL files, since the API name (and file name) can be derived without extra
annotations.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190122

[dmichael (off chromium), 2013-03-20 16:50:37]

lgtm

https://codereview.chromium.org/12702011/diff/1/ppapi/generators/idl_thunk.py
File ppapi/generators/idl_thunk.py (right):

https://codereview.chromium.org/12702011/diff/1/ppapi/generators/idl_thunk.py...
ppapi/generators/idl_thunk.py:108: # Clip off _dev suffix.
s/_dev/_trusted

https://codereview.chromium.org/12702011/diff/1/webkit/plugins/ppapi/ppb_buff...
File webkit/plugins/ppapi/ppb_buffer_impl.h (left):

https://codereview.chromium.org/12702011/diff/1/webkit/plugins/ppapi/ppb_buff...
webkit/plugins/ppapi/ppb_buffer_impl.h:46: // PPB_BufferTrusted_API
implementation.
I think it's worth still commenting that this is Trusted.

[teravest, 2013-03-20 17:03:06]

+yzshen for content/renderer/pepper/OWNERS

[teravest, 2013-03-20 17:03:27]

https://codereview.chromium.org/12702011/diff/1/ppapi/generators/idl_thunk.py
File ppapi/generators/idl_thunk.py (right):

https://codereview.chromium.org/12702011/diff/1/ppapi/generators/idl_thunk.py...
ppapi/generators/idl_thunk.py:108: # Clip off _dev suffix.
On 2013/03/20 16:50:37, dmichael wrote:
> s/_dev/_trusted

Done.

https://codereview.chromium.org/12702011/diff/1/webkit/plugins/ppapi/ppb_buff...
File webkit/plugins/ppapi/ppb_buffer_impl.h (left):

https://codereview.chromium.org/12702011/diff/1/webkit/plugins/ppapi/ppb_buff...
webkit/plugins/ppapi/ppb_buffer_impl.h:46: // PPB_BufferTrusted_API
implementation.
On 2013/03/20 16:50:37, dmichael wrote:
> I think it's worth still commenting that this is Trusted.

Done.

[yzshen1, 2013-03-20 17:08:38]

https://codereview.chromium.org/12702011/diff/5001/ppapi/proxy/ppb_buffer_pro...
File ppapi/proxy/ppb_buffer_proxy.cc (right):

https://codereview.chromium.org/12702011/diff/5001/ppapi/proxy/ppb_buffer_pro...
ppapi/proxy/ppb_buffer_proxy.cc:19: #include
"ppapi/thunk/ppb_buffer_trusted_api.h"
This needs to be changed, right?

https://codereview.chromium.org/12702011/diff/5001/ppapi/proxy/ppp_content_de...
File ppapi/proxy/ppp_content_decryptor_private_proxy.cc (right):

https://codereview.chromium.org/12702011/diff/5001/ppapi/proxy/ppp_content_de...
ppapi/proxy/ppp_content_decryptor_private_proxy.cc:21: #include
"ppapi/thunk/ppb_buffer_trusted_api.h"
ditto.

https://codereview.chromium.org/12702011/diff/5001/webkit/plugins/ppapi/ppb_b...
File webkit/plugins/ppapi/ppb_buffer_impl.h (left):

https://codereview.chromium.org/12702011/diff/5001/webkit/plugins/ppapi/ppb_b...
webkit/plugins/ppapi/ppb_buffer_impl.h:13: #include
"ppapi/thunk/ppb_buffer_trusted_api.h"
This is not needed. Right?

[teravest, 2013-03-20 17:12:41]

Thanks for catching the stale includes. Removed.

https://codereview.chromium.org/12702011/diff/5001/ppapi/proxy/ppb_buffer_pro...
File ppapi/proxy/ppb_buffer_proxy.cc (right):

https://codereview.chromium.org/12702011/diff/5001/ppapi/proxy/ppb_buffer_pro...
ppapi/proxy/ppb_buffer_proxy.cc:19: #include
"ppapi/thunk/ppb_buffer_trusted_api.h"
On 2013/03/20 17:08:38, yzshen1 wrote:
> This needs to be changed, right?

Done.

https://codereview.chromium.org/12702011/diff/5001/ppapi/proxy/ppp_content_de...
File ppapi/proxy/ppp_content_decryptor_private_proxy.cc (right):

https://codereview.chromium.org/12702011/diff/5001/ppapi/proxy/ppp_content_de...
ppapi/proxy/ppp_content_decryptor_private_proxy.cc:21: #include
"ppapi/thunk/ppb_buffer_trusted_api.h"
On 2013/03/20 17:08:38, yzshen1 wrote:
> ditto.

Done.

https://codereview.chromium.org/12702011/diff/5001/webkit/plugins/ppapi/ppb_b...
File webkit/plugins/ppapi/ppb_buffer_impl.h (left):

https://codereview.chromium.org/12702011/diff/5001/webkit/plugins/ppapi/ppb_b...
webkit/plugins/ppapi/ppb_buffer_impl.h:13: #include
"ppapi/thunk/ppb_buffer_trusted_api.h"
On 2013/03/20 17:08:38, yzshen1 wrote:
> This is not needed. Right?

Done.

[yzshen1, 2013-03-20 17:18:47]

lgtm

[commit-bot: I haz the power, 2013-03-20 17:20:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/12702011/9001

[commit-bot: I haz the power, 2013-03-20 17:42:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[teravest, 2013-03-20 20:08:53]

Looks like the proxy wasn't handling GetSharedMemory(), and I forgot to add it.
Fixing that now.

[commit-bot: I haz the power, 2013-03-20 21:12:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/12702011/26001

[commit-bot: I haz the power, 2013-03-20 23:11:00]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-03-21 14:30:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/12702011/26001

[commit-bot: I haz the power, 2013-03-22 18:32:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/12702011/26001

[commit-bot: I haz the power, 2013-03-23 15:18:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/12702011/26001

[commit-bot: I haz the power, 2013-03-23 23:50:50]

Change committed as 190122