Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 12702005: Use IsRuntimeEntry for RUNTIME_ENTRY comparison (Closed)

Created:
7 years, 9 months ago by haitao.feng
Modified:
7 years, 9 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Use IsRuntimeEntry for RUNTIME_ENTRY comparison Committed: http://code.google.com/p/v8/source/detail?r=13929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/arm/assembler-arm-inl.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips-inl.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
Replaced "rmode_ == RUNTIME_ENTRY" with IsRuntimeEntry(rmode_). I replaced parts of them in https://codereview.chromium.org/11574027/. Now there ...
7 years, 9 months ago (2013-03-12 23:49:20 UTC) #1
danno
lgtm, I'll land this for you.
7 years, 9 months ago (2013-03-13 10:53:03 UTC) #2
danno
7 years, 9 months ago (2013-03-13 11:40:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13929 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698