Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1270193002: Add new memory histograms which fix inprecise bucketing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the units of the new metrics Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_memory_details.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 8a48a1b029da63e2d36369194ab1f8820d78aa90..2b1c1b9b834643f34d0789320d66ec4c78a00b6e 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -17251,8 +17251,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<owner>kenjibaheux@google.com</owner>
<owner>kouhei@chromium.org</owner>
<summary>
- The sum of all processes' swap. Recorded once per UMA ping if the system
- has swapped.
+ The sum of all processes' swap. Recorded once per UMA ping if the system has
+ swapped. See Memory.Swap.Total2 for the same metric with higher precision
+ bucketing.
+ </summary>
+</histogram>
+
+<histogram name="Memory.Swap.Total2" units="MiB">
+ <owner>hajimehoshi@chromium.org</owner>
+ <owner>kenjibaheux@google.com</owner>
+ <owner>kouhei@chromium.org</owner>
+ <owner>rkaplow@chromium.org</owner>
+ <summary>
+ The sum of all processes' swap. Recorded once per UMA ping if the system has
+ swapped.
</summary>
</histogram>
@@ -17280,7 +17292,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<owner>hajimehoshi@chromium.org</owner>
<owner>kenjibaheux@google.com</owner>
<owner>kouhei@chromium.org</owner>
- <summary>The sum of all processes. Recorded once per UMA ping.</summary>
+ <summary>
+ The sum of all processes. This is not aware of shared memory so it is just a
+ rough estimate. Recorded once per UMA ping. See Memory.Total2 for the same
+ metric with higher precision bucketing.
+ </summary>
+</histogram>
+
+<histogram name="Memory.Total2" units="MiB">
+ <owner>hajimehoshi@chromium.org</owner>
+ <owner>kenjibaheux@google.com</owner>
+ <owner>kouhei@chromium.org</owner>
+ <owner>rkaplow@chromium.org</owner>
+ <summary>
+ The sum of all processes. This is not aware of shared memory so it is just a
+ rough estimate. Recorded once per UMA ping.
+ </summary>
</histogram>
<histogram name="Memory.Utility" units="KB">
« no previous file with comments | « chrome/browser/metrics/metrics_memory_details.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698