service/datastore/pls_impl.go - Issue 1270113002: Re-add metadata passthrough on Get operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/pls_impl.go

Issue 1270113002: Re-add metadata passthrough on Get operations (Closed) Base URL: https://github.com/luci/gae.git@fix_other_interfaces

Patch Set: add another test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/pls_impl.go

diff --git a/service/datastore/pls_impl.go b/service/datastore/pls_impl.go

index 9a369123c59cf58b2431ab169fa568f2638bcfea..7e584779bd44c56011b4987ff347f5aa53c743fa 100644

--- a/service/datastore/pls_impl.go

+++ b/service/datastore/pls_impl.go

@@ -340,6 +340,10 @@ func (p *structPLS) GetMeta(key string) (interface{}, error) {

return val, nil

}

+func (p *structPLS) GetMetaDefault(key string, def interface{}) interface{} {

+ return GetMetaDefaultImpl(p.GetMeta, key, def)

func (p *structPLS) SetMeta(key string, val interface{}) (err error) {

if err = p.Problem(); err != nil {

return