Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: service/datastore/datastore.go

Issue 1270113002: Re-add metadata passthrough on Get operations (Closed) Base URL: https://github.com/luci/gae.git@fix_other_interfaces
Patch Set: add another test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: service/datastore/datastore.go
diff --git a/service/datastore/datastore.go b/service/datastore/datastore.go
index b4f1220b0f1311b5753a4c8b511b811415e1883a..24e1d24253e6f5dbf3f82504b722b42e8e57171b 100644
--- a/service/datastore/datastore.go
+++ b/service/datastore/datastore.go
@@ -127,14 +127,14 @@ func (d *datastoreImpl) GetMulti(dst interface{}) error {
return fmt.Errorf("invalid GetMulti input type: %T", dst)
}
- keys, err := mat.GetKeys(d.NewKey, slice)
+ keys, pms, err := mat.GetKeysPMs(d.NewKey, slice)
if err != nil {
return err
}
lme := errors.LazyMultiError{Size: len(keys)}
i := 0
- err = d.RawInterface.GetMulti(keys, func(pm PropertyMap, err error) {
+ err = d.RawInterface.GetMulti(keys, NewMultiMeta(pms), func(pm PropertyMap, err error) {
if !lme.Assign(i, err) {
lme.Assign(i, mat.setPM(slice.Index(i), pm))
}
@@ -154,12 +154,7 @@ func (d *datastoreImpl) PutMulti(src interface{}) error {
return fmt.Errorf("invalid PutMulti input type: %T", src)
}
- keys, err := mat.GetKeys(d.NewKey, slice)
- if err != nil {
- return err
- }
-
- vals, err := mat.GetPMs(slice)
+ keys, vals, err := mat.GetKeysPMs(d.NewKey, slice)
if err != nil {
return err
}

Powered by Google App Engine
This is Rietveld 408576698