Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: service/datastore/checkfilter_test.go

Issue 1270113002: Re-add metadata passthrough on Get operations (Closed) Base URL: https://github.com/luci/gae.git@fix_other_interfaces
Patch Set: cleanup Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/checkfilter.go ('k') | service/datastore/datastore.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/checkfilter_test.go
diff --git a/service/datastore/checkfilter_test.go b/service/datastore/checkfilter_test.go
index bdc661a52c57ee90ba07fde78a5fd9c5848e1c69..f118d57658c130c9d45199739fd8038712dd3053 100644
--- a/service/datastore/checkfilter_test.go
+++ b/service/datastore/checkfilter_test.go
@@ -58,12 +58,12 @@ func TestCheckFilter(t *testing.T) {
})
Convey("GetMulti", func() {
- So(rds.GetMulti(nil, nil), ShouldBeNil)
- So(rds.GetMulti([]Key{NewKey("", "", "", "", 0, nil)}, nil).Error(), ShouldContainSubstring, "is nil")
+ So(rds.GetMulti(nil, nil, nil), ShouldBeNil)
+ So(rds.GetMulti([]Key{NewKey("", "", "", "", 0, nil)}, nil, nil).Error(), ShouldContainSubstring, "is nil")
// this is in the wrong aid/ns
keys := []Key{NewKey("wut", "wrong", "Kind", "", 1, nil)}
- So(rds.GetMulti(keys, func(pm PropertyMap, err error) {
+ So(rds.GetMulti(keys, nil, func(pm PropertyMap, err error) {
So(pm, ShouldBeNil)
So(err, ShouldEqual, ErrInvalidKey)
}), ShouldBeNil)
@@ -71,7 +71,7 @@ func TestCheckFilter(t *testing.T) {
keys[0] = NewKey("aid", "ns", "Kind", "", 1, nil)
hit := false
So(func() {
- rds.GetMulti(keys, func(pm PropertyMap, err error) {
+ rds.GetMulti(keys, nil, func(pm PropertyMap, err error) {
hit = true
})
}, ShouldPanic)
« no previous file with comments | « service/datastore/checkfilter.go ('k') | service/datastore/datastore.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698