impl/dummy/dummy.go - Issue 1270113002: Re-add metadata passthrough on Get operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/dummy/dummy.go

Issue 1270113002: Re-add metadata passthrough on Get operations (Closed) Base URL: https://github.com/luci/gae.git@fix_other_interfaces

Patch Set: safer, add tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/dummy/dummy.go

diff --git a/impl/dummy/dummy.go b/impl/dummy/dummy.go

index 75a4f60ff304288caa277e658083ca56099ee1bf..3ce115f8827b7729b85ca8cf2c0261f0d1be9ffb 100644

--- a/impl/dummy/dummy.go

+++ b/impl/dummy/dummy.go

@@ -71,7 +71,9 @@ func (ds) DecodeKey(string) (datastore.Key, error) { panic(ni()) }

func (ds) PutMulti([]datastore.Key, []datastore.PropertyMap, datastore.PutMultiCB) error {

panic(ni())

}

-func (ds) GetMulti([]datastore.Key, datastore.GetMultiCB) error { panic(ni()) }

+func (ds) GetMulti([]datastore.Key, datastore.MultiMetaGetter, datastore.GetMultiCB) error {

+ panic(ni())

func (ds) DeleteMulti([]datastore.Key, datastore.DeleteMultiCB) error { panic(ni()) }

func (ds) NewQuery(string) datastore.Query { panic(ni()) }

func (ds) Run(datastore.Query, datastore.RawRunCB) error { panic(ni()) }