Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: service/datastore/properties_test.go

Issue 1270113002: Re-add metadata passthrough on Get operations (Closed) Base URL: https://github.com/luci/gae.git@fix_other_interfaces
Patch Set: safer, add tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package datastore 5 package datastore
6 6
7 import ( 7 import (
8 "math" 8 "math"
9 "testing" 9 "testing"
10 "time" 10 "time"
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 pm := PropertyMap{"": {MkProperty("trap!")}} 148 pm := PropertyMap{"": {MkProperty("trap!")}}
149 _, err := pm.GetMeta("foo") 149 _, err := pm.GetMeta("foo")
150 So(err, ShouldEqual, ErrMetaFieldUnset) 150 So(err, ShouldEqual, ErrMetaFieldUnset)
151 151
152 err = pm.SetMeta("foo", 100) 152 err = pm.SetMeta("foo", 100)
153 So(err, ShouldBeNil) 153 So(err, ShouldBeNil)
154 154
155 v, err := pm.GetMeta("foo") 155 v, err := pm.GetMeta("foo")
156 So(err, ShouldBeNil) 156 So(err, ShouldBeNil)
157 So(v, ShouldEqual, 100) 157 So(v, ShouldEqual, 100)
158 So(pm.GetMetaDefault("foo", 100), ShouldEqual, 1 00)
159 So(pm.GetMetaDefault("bar", 100), ShouldEqual, 1 00)
158 160
159 npm, err := pm.Save(false) 161 npm, err := pm.Save(false)
160 So(err, ShouldBeNil) 162 So(err, ShouldBeNil)
161 So(len(npm), ShouldEqual, 1) 163 So(len(npm), ShouldEqual, 1)
162 }) 164 })
163 165
164 Convey("errors", func() { 166 Convey("errors", func() {
165 Convey("too many values", func() { 167 Convey("too many values", func() {
166 pm := PropertyMap{ 168 pm := PropertyMap{
167 "$bad": {MkProperty(100), MkProp erty(200)}, 169 "$bad": {MkProperty(100), MkProp erty(200)},
168 } 170 }
169 _, err := pm.GetMeta("bad") 171 _, err := pm.GetMeta("bad")
170 So(err.Error(), ShouldContainSubstring, "too many values") 172 So(err.Error(), ShouldContainSubstring, "too many values")
171 }) 173 })
172 174
173 Convey("weird value", func() { 175 Convey("weird value", func() {
174 pm := PropertyMap{} 176 pm := PropertyMap{}
175 err := pm.SetMeta("sup", complex(100, 20 )) 177 err := pm.SetMeta("sup", complex(100, 20 ))
176 So(err.Error(), ShouldContainSubstring, "bad type") 178 So(err.Error(), ShouldContainSubstring, "bad type")
177 }) 179 })
178 }) 180 })
179 }) 181 })
180 }) 182 })
181 } 183 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698