Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: net/http/http_transaction_unittest.cc

Issue 12701011: [Net] Propagate priority changes from URLRequest to HttpTransaction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix leaks Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_transaction_unittest.h ('k') | net/net.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_transaction_unittest.cc
diff --git a/net/http/http_transaction_unittest.cc b/net/http/http_transaction_unittest.cc
index 84cba0b81d867bb5b053ce87e598ecc47385653a..3d966283ecf90b1e6be4e6564c3a6b40290539ed 100644
--- a/net/http/http_transaction_unittest.cc
+++ b/net/http/http_transaction_unittest.cc
@@ -221,6 +221,7 @@ MockNetworkTransaction::MockNetworkTransaction(
MockNetworkLayer* factory)
: ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
data_cursor_(0),
+ priority_(priority),
transaction_factory_(factory->AsWeakPtr()) {
}
@@ -328,6 +329,10 @@ bool MockNetworkTransaction::GetLoadTimingInfo(
return false;
}
+void MockNetworkTransaction::SetPriority(net::RequestPriority priority) {
+ priority_ = priority;
+}
+
void MockNetworkTransaction::CallbackLater(
const net::CompletionCallback& callback, int result) {
MessageLoop::current()->PostTask(
@@ -341,7 +346,9 @@ void MockNetworkTransaction::RunCallback(
}
MockNetworkLayer::MockNetworkLayer()
- : transaction_count_(0), done_reading_called_(false) {}
+ : transaction_count_(0),
+ done_reading_called_(false),
+ last_create_transaction_priority_(net::DEFAULT_PRIORITY) {}
MockNetworkLayer::~MockNetworkLayer() {}
@@ -354,7 +361,11 @@ int MockNetworkLayer::CreateTransaction(
scoped_ptr<net::HttpTransaction>* trans,
net::HttpTransactionDelegate* delegate) {
transaction_count_++;
- trans->reset(new MockNetworkTransaction(priority, this));
+ last_create_transaction_priority_ = priority;
+ scoped_ptr<MockNetworkTransaction> mock_transaction(
+ new MockNetworkTransaction(priority, this));
+ last_transaction_ = mock_transaction->AsWeakPtr();
+ *trans = mock_transaction.Pass();
return net::OK;
}
« no previous file with comments | « net/http/http_transaction_unittest.h ('k') | net/net.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698