[Net] Propagate priority changes from URLRequest to HttpTransaction

net/http/http_cache_transaction_unittest.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/http/http_cache_transaction.h"
+
+#include "net/http/http_cache.h"
+#include "net/http/http_transaction_unittest.h"
+#include "net/http/mock_http_cache.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+class HttpCacheTransactionTest : public ::testing::Test {
+ protected:
+  typedef HttpCache::Transaction HttpCacheTransaction;
+
+  scoped_ptr<HttpCacheTransaction> MakeCacheTransaction() {
+    scoped_ptr<HttpTransaction> trans;
+    int rv = cache_.http_cache()->CreateTransaction(&trans, NULL);
+    EXPECT_EQ(OK, rv);
+    return scoped_ptr<HttpCacheTransaction>(
+        static_cast<HttpCacheTransaction*>(trans.release()));
+  }
+
+  MockNetworkTransaction* InjectMockTransaction(
+      HttpCacheTransaction* cache_trans) {
+    MockNetworkTransaction* mock_trans = new MockNetworkTransaction(&network_);
+    cache_trans->network_trans_.reset(mock_trans);
+    return mock_trans;
+  }
+
+  MockNetworkLayer network_;
+  MockHttpCache cache_;
+};
+
+// Make sure that calling HttpCache::Transaction passes on its
+// priority updates to its underlying network transaction.
+TEST_F(HttpCacheTransactionTest, SetPriority) {

[mmenke, 2013/03/13 15:24:38]

I believe the HttpCache unittests have all the necessary infrastructure to do
this without adding any new friends.

[akalin, 2013/03/13 16:06:45]

I can't see how; the name HttpCache::Transaction isn't even public. Other than
that, how would I check that the priority of the underlying mock transaction is
set properly?

[mmenke, 2013/03/13 16:16:11]

They create the MockTransaction before the HttpCacheTransaction, and then they
use cache->CreateTransaction, passing in the mock transaction as an argument.

[mmenke, 2013/03/13 16:27:28]

The same thing I suggested in the other case will work here, though - a class
like MockNetworkLayer that keeps a pointer to a mock network transaction.

[akalin, 2013/03/13 16:57:14]

Okay that works. Since more than one thing now wants the pointer to the last
mock network transaction, just added it to MockNetworkLayer.

+  scoped_ptr<HttpCacheTransaction> trans = MakeCacheTransaction();
+
+  trans->SetPriority(LOW);
+
+  MockNetworkTransaction* mock_trans = InjectMockTransaction(trans.get());
+
+  EXPECT_EQ(IDLE, mock_trans->priority());
+
+  trans->SetPriority(MEDIUM);
+
+  EXPECT_EQ(MEDIUM, mock_trans->priority());
+}
+
+}  // namespace net
+