[Net] Propagate priority changes from URLRequest to HttpTransaction

net/http/http_transaction_unittest.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_TRANSACTION_UNITTEST_H_
 #define NET_HTTP_HTTP_TRANSACTION_UNITTEST_H_
 
 #include "net/http/http_transaction.h"
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "net/base/io_buffer.h"
 #include "net/base/load_flags.h"
 #include "net/base/net_errors.h"
 #include "net/base/request_priority.h"
 #include "net/base/test_completion_callback.h"
 #include "net/disk_cache/disk_cache.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_request_info.h"
 #include "net/http/http_response_headers.h"
@@ skipping 161 matching lines @@
 
   virtual const net::HttpResponseInfo* GetResponseInfo() const OVERRIDE;
 
   virtual net::LoadState GetLoadState() const OVERRIDE;
 
   virtual net::UploadProgress GetUploadProgress() const OVERRIDE;
 
   virtual bool GetLoadTimingInfo(
       net::LoadTimingInfo* load_timing_info) const OVERRIDE;
 
+  virtual void SetPriority(net::RequestPriority priority) OVERRIDE;
+
+  net::RequestPriority priority() const { return priority_; }
+
  private:
   void CallbackLater(const net::CompletionCallback& callback, int result);
   void RunCallback(const net::CompletionCallback& callback, int result);
 
   base::WeakPtrFactory<MockNetworkTransaction> weak_factory_;
   net::HttpResponseInfo response_;
   std::string data_;
   int data_cursor_;
   int test_mode_;
+  net::RequestPriority priority_;
   base::WeakPtr<MockNetworkLayer> transaction_factory_;
 };
 
 class MockNetworkLayer : public net::HttpTransactionFactory,
                          public base::SupportsWeakPtr<MockNetworkLayer> {
  public:
   MockNetworkLayer();
   virtual ~MockNetworkLayer();
 
   int transaction_count() const { return transaction_count_; }
   bool done_reading_called() const { return done_reading_called_; }
   void TransactionDoneReading();
 
+  // Returns the last transaction created by CreateTransaction, or
+  // NULL if one has not been created yet.

[mmenke, 2013/03/21 15:39:23]

Think it's worth noting that this owns a reference, so the mock transaction is
safe to call after it would normally be destroyed.  Also think it may be a good
idea to throw a const or two in the declaration, to make it clear that it's not
intended to be used as an opportunity to muck with the transaction.

[akalin, 2013/03/21 23:43:48]

Turns out the DelegatingTransaction approach doesn't work either. Changed it so
that last_transaction() returns a WeakPtr<MockNetworkTransaction>.

+  MockNetworkTransaction* last_transaction() {
+    return last_transaction_.get();
+  }
+
+  // Makes last_transaction() return NULL until the next transaction
+  // is created.
+  void ClearLastTransaction() {
+    last_transaction_.reset();
+  }
+
   // net::HttpTransactionFactory:
   virtual int CreateTransaction(
       net::RequestPriority priority,
       scoped_ptr<net::HttpTransaction>* trans,
       net::HttpTransactionDelegate* delegate) OVERRIDE;
   virtual net::HttpCache* GetCache() OVERRIDE;
   virtual net::HttpNetworkSession* GetSession() OVERRIDE;
 
  private:
   int transaction_count_;
   bool done_reading_called_;
+  scoped_ptr<MockNetworkTransaction> last_transaction_;
 };
 
 //-----------------------------------------------------------------------------
 // helpers
 
 // read the transaction completely
 int ReadTransaction(net::HttpTransaction* trans, std::string* result);
 
 #endif  // NET_HTTP_HTTP_TRANSACTION_UNITTEST_H_