[Net] Propagate priority changes from URLRequest to HttpTransaction

net/url_request/url_request_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shlobj.h>
 #endif
@@ skipping 1386 matching lines @@
 // content is empty.
 TEST_F(URLRequestTest, RequestCompletionForEmptyResponse) {
   TestDelegate d;
   URLRequest req(GURL("data:,"), &d, &default_context_);
   req.Start();
   MessageLoop::current()->Run();
   EXPECT_EQ("", d.data_received());
   EXPECT_EQ(1, default_network_delegate_.completed_requests());
 }
 
+// Make sure that URLRequest passes on its priority updates to its
+// job.
+TEST_F(URLRequestTest, Priority) {
+  TestInterceptor interceptor;
+
+  interceptor.intercept_main_request_ = true;

[mmenke, 2013/03/12 18:40:22]

Rather than having URLRequest friend the individual test, how about using
URLRequestTest::AddTestInterceptor().

Then you can set the TestJobInterceptor return return a URLRequestTestJob
created by the test.  This also avoids the cast, as well as using the deprecated
Interceptor class.

[akalin, 2013/03/12 22:08:28]

Done.

+
+  TestDelegate d;
+  URLRequest req(GURL("http://test_intercept/foo"), &d, &default_context_);
+  EXPECT_EQ(LOWEST, req.priority());
+  EXPECT_TRUE(!req.job_);
+
+  req.SetPriority(IDLE);
+  EXPECT_EQ(IDLE, req.priority());
+  EXPECT_TRUE(!req.job_);
+
+  req.Start();
+  EXPECT_TRUE(req.job_ != NULL);
+  scoped_refptr<URLRequestTestJob> job(
+      static_cast<URLRequestTestJob*>(req.job_.get()));
+  EXPECT_EQ(IDLE, job->priority());
+
+  req.SetPriority(HIGHEST);
+  EXPECT_EQ(HIGHEST, req.priority());
+  EXPECT_EQ(HIGHEST, job->priority());
+}
+
 // TODO(droger): Support TestServer on iOS (see http://crbug.com/148666).
 #if !defined(OS_IOS)
 // A subclass of TestServer that uses a statically-configured hostname. This is
 // to work around mysterious failures in chrome_frame_net_tests. See:
 // http://crbug.com/114369
 class LocalHttpTestServer : public TestServer {
  public:
   explicit LocalHttpTestServer(const base::FilePath& document_root)
       : TestServer(TestServer::TYPE_HTTP,
                    ScopedCustomUrlRequestTestHttpHost::value(),
@@ skipping 3950 matching lines @@
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d->response_started_count());
     EXPECT_FALSE(d->received_data_before_response());
     EXPECT_EQ(d->bytes_received(), static_cast<int>(file_size));
   }
 }
 #endif  // !defined(DISABLE_FTP_SUPPORT)
 
 }  // namespace net