[Net] Propagate priority changes from URLRequest to HttpTransaction

net/url_request/url_request_http_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 1560 matching lines @@
   DCHECK(transaction_->GetResponseInfo());
   return override_response_headers_.get() ?
       override_response_headers_ :
       transaction_->GetResponseInfo()->headers;
 }
 
 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
   awaiting_callback_ = false;
 }
 
+void URLRequestHttpJob::SetPriority(RequestPriority priority) {

[mmenke, 2013/03/12 18:40:22]

request_info_.priority = priority;?

We may want to separate priority out from request_info_ in a future CL.  I
believe request_info_ is currently constant for the duration of a transaction,
and seems a little unexpected to be changing something that's constant out from
under lower level objects that have access to it, even if we notify them of the
change.

Downside of that is that we'd need to track the priority directly at a couple
levels that we currently just rely on a pointer to the HttpRequestInfo for.

[akalin, 2013/03/12 22:08:28]

Done, added TODO to separate out priority.

+  if (transaction_.get())

[mmenke, 2013/03/12 18:40:22]

nit:  "transaction_" is now preferred.  This file uses .get() a lot
unnecessarily, for legacy reasons, but figure we should stick with the preferred
style for new code.

[akalin, 2013/03/12 22:08:28]

Done.

+    transaction_->SetPriority(priority);
+}
+
 void URLRequestHttpJob::OnDetachRequest() {
   http_transaction_delegate_->OnDetachRequest();
 }
 
 }  // namespace net