Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 12701004: Revert 185715 (Closed)

Created:
7 years, 9 months ago by sail
Modified:
7 years, 9 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Revert 185715 > Mac: Audio indicator in each tab > > This is the Mac version of this views CL: > https://chromiumcodereview.appspot.com/12328027/ > > When audio is playing a throbber animation is displayed in the tab. > > BUG=3541 > TEST= > Navigate to http://www.html5rocks.com/en/tutorials/video/basics/ > Play video. Verify that throbber is displayed over the fav icon. > Pause video. Verify that throbber stops. > > > Review URL: https://chromiumcodereview.appspot.com/12374042 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sail
7 years, 9 months ago (2013-03-10 18:51:44 UTC) #1
sail
7 years, 9 months ago (2013-03-10 18:52:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r187216.

Powered by Google App Engine
This is Rietveld 408576698