Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: filter/featureBreaker/tq.go

Issue 1270063003: Make the rest of the services have a similar raw/user interface structure. (Closed) Base URL: https://github.com/luci/gae.git@add_datastore
Patch Set: address comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « filter/featureBreaker/mc.go ('k') | impl/dummy/dummy.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/featureBreaker/tq.go
diff --git a/filter/featureBreaker/tq.go b/filter/featureBreaker/tq.go
index 16c2508acf6a75578539934e09545e883d5f6960..6754d325f7e53c79de97b2e0c2ad683973997de1 100644
--- a/filter/featureBreaker/tq.go
+++ b/filter/featureBreaker/tq.go
@@ -13,79 +13,31 @@ import (
type tqState struct {
*state
- tq tq.Interface
+ tq tq.RawInterface
}
-var _ tq.Interface = (*tqState)(nil)
+var _ tq.RawInterface = (*tqState)(nil)
-func (t *tqState) Add(task *tq.Task, queueName string) (ret *tq.Task, err error) {
- err = t.run(func() (err error) {
- ret, err = t.tq.Add(task, queueName)
- return
- })
- return
+func (t *tqState) AddMulti(tasks []*tq.Task, queueName string, cb tq.RawTaskCB) error {
+ return t.run(func() (err error) { return t.tq.AddMulti(tasks, queueName, cb) })
}
-func (t *tqState) Delete(task *tq.Task, queueName string) error {
- return t.run(func() error {
- return t.tq.Delete(task, queueName)
- })
-}
-
-func (t *tqState) AddMulti(tasks []*tq.Task, queueName string) (ret []*tq.Task, err error) {
- err = t.run(func() (err error) {
- ret, err = t.tq.AddMulti(tasks, queueName)
- return
- })
- return
-}
-
-func (t *tqState) DeleteMulti(tasks []*tq.Task, queueName string) error {
- return t.run(func() error {
- return t.tq.DeleteMulti(tasks, queueName)
- })
-}
-
-func (t *tqState) Lease(maxTasks int, queueName string, leaseTime int) (ret []*tq.Task, err error) {
- err = t.run(func() (err error) {
- ret, err = t.tq.Lease(maxTasks, queueName, leaseTime)
- return
- })
- return
-}
-
-func (t *tqState) LeaseByTag(maxTasks int, queueName string, leaseTime int, tag string) (ret []*tq.Task, err error) {
- err = t.run(func() (err error) {
- ret, err = t.tq.LeaseByTag(maxTasks, queueName, leaseTime, tag)
- return
- })
- return
-}
-
-func (t *tqState) ModifyLease(task *tq.Task, queueName string, leaseTime int) error {
- return t.run(func() error {
- return t.tq.ModifyLease(task, queueName, leaseTime)
- })
+func (t *tqState) DeleteMulti(tasks []*tq.Task, queueName string, cb tq.RawCB) error {
+ return t.run(func() error { return t.tq.DeleteMulti(tasks, queueName, cb) })
}
func (t *tqState) Purge(queueName string) error {
- return t.run(func() error {
- return t.tq.Purge(queueName)
- })
+ return t.run(func() error { return t.tq.Purge(queueName) })
}
-func (t *tqState) QueueStats(queueNames []string) (ret []tq.Statistics, err error) {
- err = t.run(func() (err error) {
- ret, err = t.tq.QueueStats(queueNames)
- return
- })
- return
+func (t *tqState) Stats(queueNames []string, cb tq.RawStatsCB) error {
+ return t.run(func() error { return t.tq.Stats(queueNames, cb) })
}
// FilterTQ installs a counter TaskQueue filter in the context.
func FilterTQ(c context.Context, defaultError error) (context.Context, FeatureBreaker) {
state := newState(defaultError)
- return tq.AddFilters(c, func(ic context.Context, tq tq.Interface) tq.Interface {
+ return tq.AddRawFilters(c, func(ic context.Context, tq tq.RawInterface) tq.RawInterface {
return &tqState{state, tq}
}), state
}
« no previous file with comments | « filter/featureBreaker/mc.go ('k') | impl/dummy/dummy.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698