Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Side by Side Diff: service/memcache/context.go

Issue 1270063003: Make the rest of the services have a similar raw/user interface structure. (Closed) Base URL: https://github.com/luci/gae.git@add_datastore
Patch Set: address comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « service/datastore/context.go ('k') | service/memcache/interface.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package memcache 5 package memcache
6 6
7 import ( 7 import (
8 "golang.org/x/net/context" 8 "golang.org/x/net/context"
9 ) 9 )
10 10
11 type key int 11 type key int
12 12
13 var ( 13 var (
14 memcacheKey key 14 memcacheKey key
15 memcacheFilterKey key = 1 15 memcacheFilterKey key = 1
16 ) 16 )
17 17
18 // Factory is the function signature for factory methods compatible with 18 // RawFactory is the function signature for RawFactory methods compatible with
19 // SetFactory. 19 // SetRawFactory.
20 type Factory func(context.Context) Interface 20 type RawFactory func(context.Context) RawInterface
21 21
22 // Filter is the function signature for a filter MC implementation. It 22 // RawFilter is the function signature for a RawFilter MC implementation. It
23 // gets the current MC implementation, and returns a new MC implementation 23 // gets the current MC implementation, and returns a new MC implementation
24 // backed by the one passed in. 24 // backed by the one passed in.
25 type Filter func(context.Context, Interface) Interface 25 type RawFilter func(context.Context, RawInterface) RawInterface
26 26
27 // getUnfiltered gets gets the Interface implementation from context without 27 // getUnfiltered gets gets the RawInterface implementation from context without
28 // any of the filters applied. 28 // any of the filters applied.
29 func getUnfiltered(c context.Context) Interface { 29 func getUnfiltered(c context.Context) RawInterface {
30 » if f, ok := c.Value(memcacheKey).(Factory); ok && f != nil { 30 » if f, ok := c.Value(memcacheKey).(RawFactory); ok && f != nil {
31 return f(c) 31 return f(c)
32 } 32 }
33 return nil 33 return nil
34 } 34 }
35 35
36 // Get gets the current memcache implementation from the context. 36 // GetRaw gets the current memcache implementation from the context.
37 func Get(c context.Context) Interface { 37 func GetRaw(c context.Context) RawInterface {
38 ret := getUnfiltered(c) 38 ret := getUnfiltered(c)
39 if ret == nil { 39 if ret == nil {
40 return nil 40 return nil
41 } 41 }
42 for _, f := range getCurFilters(c) { 42 for _, f := range getCurFilters(c) {
43 ret = f(c, ret) 43 ret = f(c, ret)
44 } 44 }
45 return ret 45 return ret
46 } 46 }
47 47
48 // SetFactory sets the function to produce Interface instances, as returned by 48 // SetRawFactory sets the function to produce RawInterface instances, as returne d by
49 // the Get method. 49 // the Get method.
50 func SetFactory(c context.Context, mcf Factory) context.Context { 50 func SetRawFactory(c context.Context, mcf RawFactory) context.Context {
51 return context.WithValue(c, memcacheKey, mcf) 51 return context.WithValue(c, memcacheKey, mcf)
52 } 52 }
53 53
54 // Set sets the current Interface object in the context. Useful for testing 54 // SetRaw sets the current RawInterface object in the context. Useful for testin g
55 // with a quick mock. This is just a shorthand SetFactory invocation to set 55 // with a quick mock. This is just a shorthand SetRawFactory invocation to SetRa w
56 // a factory which always returns the same object. 56 // a RawFactory which always returns the same object.
57 func Set(c context.Context, mc Interface) context.Context { 57 func SetRaw(c context.Context, mc RawInterface) context.Context {
58 » return SetFactory(c, func(context.Context) Interface { return mc }) 58 » return SetRawFactory(c, func(context.Context) RawInterface { return mc } )
59 } 59 }
60 60
61 func getCurFilters(c context.Context) []Filter { 61 func getCurFilters(c context.Context) []RawFilter {
62 curFiltsI := c.Value(memcacheFilterKey) 62 curFiltsI := c.Value(memcacheFilterKey)
63 if curFiltsI != nil { 63 if curFiltsI != nil {
64 » » return curFiltsI.([]Filter) 64 » » return curFiltsI.([]RawFilter)
65 } 65 }
66 return nil 66 return nil
67 } 67 }
68 68
69 // AddFilters adds Interface filters to the context. 69 // AddRawFilters adds RawInterface filters to the context.
70 func AddFilters(c context.Context, filts ...Filter) context.Context { 70 func AddRawFilters(c context.Context, filts ...RawFilter) context.Context {
71 if len(filts) == 0 { 71 if len(filts) == 0 {
72 return c 72 return c
73 } 73 }
74 cur := getCurFilters(c) 74 cur := getCurFilters(c)
75 » newFilts := make([]Filter, 0, len(cur)+len(filts)) 75 » newFilts := make([]RawFilter, 0, len(cur)+len(filts))
76 newFilts = append(newFilts, getCurFilters(c)...) 76 newFilts = append(newFilts, getCurFilters(c)...)
77 newFilts = append(newFilts, filts...) 77 newFilts = append(newFilts, filts...)
78 return context.WithValue(c, memcacheFilterKey, newFilts) 78 return context.WithValue(c, memcacheFilterKey, newFilts)
79 } 79 }
OLDNEW
« no previous file with comments | « service/datastore/context.go ('k') | service/memcache/interface.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698