Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270063002: Rename rawdatastore -> datastore (Closed)

Created:
5 years, 4 months ago by iannucci
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more rename #

Patch Set 3 : and a bit more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -8822 lines) Patch
M filter/count/count_test.go View 5 chunks +28 lines, -28 lines 0 comments Download
M filter/count/rds.go View 1 2 chunks +28 lines, -28 lines 0 comments Download
M filter/featureBreaker/featurebreaker_test.go View 3 chunks +14 lines, -14 lines 0 comments Download
M filter/featureBreaker/rds.go View 3 chunks +11 lines, -11 lines 0 comments Download
M impl/dummy/dummy.go View 4 chunks +18 lines, -18 lines 0 comments Download
M impl/dummy/dummy_test.go View 2 chunks +6 lines, -6 lines 0 comments Download
M impl/memory/context.go View 5 chunks +5 lines, -5 lines 0 comments Download
M impl/memory/plist.go View 9 chunks +11 lines, -11 lines 0 comments Download
M impl/memory/plist_test.go View 14 chunks +62 lines, -62 lines 0 comments Download
M impl/memory/raw_datastore.go View 5 chunks +23 lines, -23 lines 0 comments Download
M impl/memory/raw_datastore_data.go View 17 chunks +52 lines, -52 lines 0 comments Download
M impl/memory/raw_datastore_query.go View 11 chunks +19 lines, -19 lines 0 comments Download
M impl/memory/raw_datastore_test.go View 1 2 25 chunks +123 lines, -123 lines 0 comments Download
M impl/memory/taskqueue_data.go View 3 chunks +5 lines, -5 lines 0 comments Download
M impl/memory/taskqueue_test.go View 10 chunks +10 lines, -10 lines 0 comments Download
M impl/memory/testing_utils_test.go View 3 chunks +11 lines, -11 lines 0 comments Download
M impl/prod/datastore_key.go View 3 chunks +8 lines, -8 lines 0 comments Download
M impl/prod/raw_datastore.go View 8 chunks +25 lines, -25 lines 0 comments Download
M impl/prod/raw_datastore_type_converter.go View 2 chunks +12 lines, -12 lines 0 comments Download
A + service/datastore/checkfilter.go View 3 chunks +3 lines, -3 lines 0 comments Download
A + service/datastore/context.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/context_test.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/errors.go View 2 chunks +2 lines, -2 lines 0 comments Download
A + service/datastore/generic_key.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/internal/protos/datastore/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + service/datastore/internal/protos/datastore/datastore_v3.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + service/datastore/internal/protos/datastore/datastore_v3.pb.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + service/datastore/invertible.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/invertible_test.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/key.go View 2 chunks +2 lines, -2 lines 0 comments Download
A + service/datastore/key_test.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/pls.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/pls_impl.go View 2 chunks +2 lines, -2 lines 0 comments Download
A + service/datastore/pls_test.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/properties.go View 3 chunks +3 lines, -3 lines 0 comments Download
A + service/datastore/properties_test.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/raw_interface.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/reflect.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/serialize.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/serialize_test.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/types.go View 2 chunks +2 lines, -2 lines 0 comments Download
D service/rawdatastore/checkfilter.go View 1 chunk +0 lines, -123 lines 0 comments Download
D service/rawdatastore/context.go View 1 chunk +0 lines, -79 lines 0 comments Download
D service/rawdatastore/context_test.go View 1 chunk +0 lines, -57 lines 0 comments Download
D service/rawdatastore/datastore.go View 1 chunk +0 lines, -31 lines 0 comments Download
D service/rawdatastore/datastore_impl.go View 1 chunk +0 lines, -581 lines 0 comments Download
D service/rawdatastore/datastore_key.go View 1 chunk +0 lines, -232 lines 0 comments Download
D service/rawdatastore/datastore_key_test.go View 1 chunk +0 lines, -243 lines 0 comments Download
D service/rawdatastore/datastore_test.go View 1 chunk +0 lines, -1747 lines 0 comments Download
D service/rawdatastore/errors.go View 1 chunk +0 lines, -42 lines 0 comments Download
D service/rawdatastore/generic_key.go View 1 chunk +0 lines, -105 lines 0 comments Download
D service/rawdatastore/interface.go View 1 chunk +0 lines, -127 lines 0 comments Download
D service/rawdatastore/internal/protos/datastore/README.md View 1 chunk +0 lines, -5 lines 0 comments Download
D service/rawdatastore/internal/protos/datastore/datastore_v3.proto View 1 chunk +0 lines, -541 lines 0 comments Download
D service/rawdatastore/internal/protos/datastore/datastore_v3.pb.go View 1 chunk +0 lines, -2776 lines 0 comments Download
D service/rawdatastore/invertible.go View 1 chunk +0 lines, -115 lines 0 comments Download
D service/rawdatastore/invertible_test.go View 1 chunk +0 lines, -89 lines 0 comments Download
D service/rawdatastore/properties.go View 1 chunk +0 lines, -451 lines 0 comments Download
D service/rawdatastore/properties_test.go View 1 chunk +0 lines, -181 lines 0 comments Download
D service/rawdatastore/reflect.go View 1 chunk +0 lines, -28 lines 0 comments Download
D service/rawdatastore/serialize.go View 1 chunk +0 lines, -377 lines 0 comments Download
D service/rawdatastore/serialize_test.go View 1 chunk +0 lines, -330 lines 0 comments Download
D service/rawdatastore/types.go View 1 chunk +0 lines, -67 lines 0 comments Download

Dependent Patchsets:

Issue 1259593005 Patch 140001

Messages

Total messages: 4 (0 generated)
iannucci
5 years, 4 months ago (2015-08-03 20:21:03 UTC) #1
iannucci
On 2015/08/03 20:21:03, iannucci wrote: PTAL, this removes a bunch of noise from https://codereview.chromium.org/1259593005/ and ...
5 years, 4 months ago (2015-08-03 20:22:29 UTC) #2
Vadim Sh.
lgtm
5 years, 4 months ago (2015-08-03 20:56:22 UTC) #3
iannucci
5 years, 4 months ago (2015-08-03 21:03:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
bec8e9674be0c489029ccdac116a09cefbb4c29b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698