Add URLRequest unit tests for HPKP violation reports

net/test/spawned_test_server/base_test_server.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/spawned_test_server/base_test_server.h"
 
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/values.h"
 #include "net/base/address_list.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/net_errors.h"
 #include "net/base/port_util.h"
 #include "net/base/test_completion_callback.h"
 #include "net/cert/test_root_certs.h"
+#include "net/cert/x509_certificate.h"
 #include "net/dns/host_resolver.h"
 #include "net/log/net_log.h"
 #include "url/gurl.h"
 
 namespace net {
 
 namespace {
 
 std::string GetHostname(BaseTestServer::Type type,
                         const BaseTestServer::SSLOptions& options) {
@@ skipping 296 matching lines @@
     base::FilePath src_dir;
     if (!PathService::Get(base::DIR_SOURCE_ROOT, &src_dir))
       return false;
     root_certificate_path = src_dir.Append(certificates_dir_);
   }
 
   return root_certs->AddFromFile(
       root_certificate_path.AppendASCII("root_ca_cert.pem"));
 }
 
+scoped_refptr<X509Certificate> BaseTestServer::GetCertificate() const {
+  base::FilePath certificate_path(certificates_dir_);

[davidben, 2015/08/07 14:50:28]

Huh. Apparently certificates_dir_ is kind of wonky. The function above has to
correct it somewhat. And the remote test server passes in paths relative to the
source directory:
https://code.google.com/p/chromium/codesearch#chromium/src/net/test/spawned_t...

Whereas the local one is reasonable:
https://code.google.com/p/chromium/codesearch#chromium/src/net/test/spawned_t...

DIR_SOURCE_ROOT, when queried locally, is actually really funny on Android,
probably to get the isolate-based data file pushing thing to work:
https://code.google.com/p/chromium/codesearch#chromium/src/base/base_paths_an...

You might need to add a GetLocalCertificateDir() or something for what to do if
you want to read the certificate from where you are. I think right now
certificate_dir_ is suitable for wherever the test server ends up running from,
which isn't always local.

[estark, 2015/08/07 18:19:14]

Ah, so you mean that GetLocalCertificatesDir() should do what LoadTestRootCert()
does to fix up certificates_dir_? Done.

+  base::FilePath certificate_file(ssl_options_.GetCertificateFile());
+  if (certificate_file.value().empty())
+    return nullptr;
+  certificate_path = certificate_path.Append(certificate_file);
+
+  std::string cert_data;
+  if (!base::ReadFileToString(certificate_path, &cert_data))
+    return nullptr;
+
+  CertificateList certs_in_file =
+      X509Certificate::CreateCertificateListFromBytes(
+          cert_data.data(), cert_data.size(), X509Certificate::FORMAT_AUTO);

[davidben, 2015/08/07 14:50:28]

Since the test server itself only accepts PEM, I think you can assume PEM and
use FORMAT_PEM_CERT_SEQUENCE. Though ImportCertFromFile uses FORMAT_AUTO and
probably reads the same set of files, so this is fine too. *shrug* Mostly a
"explicit format is better than sniffing" thing.

[estark, 2015/08/07 18:19:14]

Done.

+  if (certs_in_file.empty())
+    return nullptr;
+  return certs_in_file[0];
+}
+
 void BaseTestServer::Init(const std::string& host) {
   host_port_pair_ = HostPortPair(host, 0);
 
   // TODO(battre) Remove this after figuring out why the TestServer is flaky.
   // http://crbug.com/96594
   log_to_console_ = true;
 }
 
 void BaseTestServer::SetResourcePath(const base::FilePath& document_root,
                                      const base::FilePath& certificates_dir) {
@@ skipping 166 matching lines @@
 
   return GenerateAdditionalArguments(arguments);
 }
 
 bool BaseTestServer::GenerateAdditionalArguments(
     base::DictionaryValue* arguments) const {
   return true;
 }
 
 }  // namespace net