Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: Source/core/dom/Position.h

Issue 1270023002: CANCEL Untemplatize PositionAlgorithm<Strategy>::rendersInDifferentPosition() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-03T15:43:25 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/Position.cpp » ('j') | Source/core/dom/Position.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Position.h
diff --git a/Source/core/dom/Position.h b/Source/core/dom/Position.h
index 5ae92d1a30215c9a5acd00406f5e44c8a748b474..562472c5e36bcb54fb1d5f57aea0ea36dc7ff5db 100644
--- a/Source/core/dom/Position.h
+++ b/Source/core/dom/Position.h
@@ -143,6 +143,12 @@ public:
// New code should not use this function.
int deprecatedEditingOffset() const;
+ // |deprecatedEditingOffset()| is used only for layout object related
+ // functions, |isRenderedCharacter()|, |inRenderedText()|, and
+ // |rendersInDifferentPosition()|.
+ // New code should not use this function.
+ int deprecatedOffset() const { return m_offset; }
+
// These are convenience methods which are smart about whether the position is neighbor anchored or parent anchored
Node* computeNodeBeforePosition() const;
Node* computeNodeAfterPosition() const;
@@ -210,7 +216,6 @@ public:
bool isCandidate() const;
bool inRenderedText() const;
bool isRenderedCharacter() const;
- bool rendersInDifferentPosition(const PositionAlgorithm<Strategy>&) const;
InlineBoxPosition computeInlineBoxPosition(EAffinity) const;
InlineBoxPosition computeInlineBoxPosition(EAffinity, TextDirection primaryDirection) const;
@@ -253,8 +258,6 @@ private:
return isAfterAnchor() || isAfterChildren();
}
- int renderedOffset() const;
-
RefPtrWillBeMember<Node> m_anchorNode;
// m_offset can be the offset inside m_anchorNode, or if editingIgnoresContent(m_anchorNode)
// returns true, then other places in editing will treat m_offset == 0 as "before the anchor"
@@ -270,6 +273,8 @@ extern template class CORE_EXTERN_TEMPLATE_EXPORT PositionAlgorithm<EditingInCom
using Position = PositionAlgorithm<EditingStrategy>;
using PositionInComposedTree = PositionAlgorithm<EditingInComposedTreeStrategy>;
+bool rendersInDifferentPosition(const Position&, const Position&);
+
inline Position createLegacyEditingPosition(PassRefPtrWillBeRawPtr<Node> node, int offset)
{
return Position::createLegacyEditingPosition(node, offset);
« no previous file with comments | « no previous file | Source/core/dom/Position.cpp » ('j') | Source/core/dom/Position.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698