Issue 12700008: remove latin-1 flag

Issue 12700008: remove latin-1 flag (Closed)

Created:
7 years, 9 months ago by dcarney

Modified:
7 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

remove latin-1 flag R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13939

Patch Set 2 : removed SeqOneByteStringVerify #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -163 lines)			Patch
M	build/common.gypi	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	include/v8.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/arm/regexp-macro-assembler-arm.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/heap.cc	View	1	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/heap-inl.h	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download
M	src/ia32/regexp-macro-assembler-ia32.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/jsregexp.cc	View		6 chunks	+0 lines, -20 lines	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
	src/objects.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/objects-debug.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/runtime.cc	View	1	9 chunks	+0 lines, -33 lines	0 comments	Download
M	src/string-search.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/unicode.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
M	test/cctest/test-strings.cc	View		3 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with comments. https://codereview.chromium.org/12700008/diff/1/src/objects-debug.cc File src/objects-debug.cc (right): https://codereview.chromium.org/12700008/diff/1/src/objects-debug.cc#newcode495 src/objects-debug.cc:495: void SeqOneByteString::SeqOneByteStringVerify() { We could remove ...

7 years, 9 months ago (2013-03-13 17:14:50 UTC) #1

dcarney

7 years, 9 months ago (2013-03-13 20:05:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r13939 (presubmit successful).

Expand Messages | Collapse Messages