Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(55)

Issue 12700007: Revert 142161 "Web Inspector: CPU pegged when inspecting LocalSt..." (Closed)

Created:
7 years, 10 months ago by eustas
Modified:
7 years, 10 months ago
Reviewers:
eustas
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Revert 142161 "Web Inspector: CPU pegged when inspecting LocalSt..." > Web Inspector: CPU pegged when inspecting LocalStorage that mutates. > https://bugs.webkit.org/show_bug.cgi?id=107937 > > Reviewed by Yury Semikhatsky. > > The DOM storage agent will fire an event to the frontend based on the action > performed on the storage. Based on this action, the front-end will just add/update/remove > the entry in the view. This enhances the front-end responsiveness as the round trip > for fetching the storage entries has been eliminated. > > Existing test: LayoutTests/inspector/storage-panel-dom-storage-update.html should verify the change > > * inspector/Inspector.json: > * inspector/InspectorDOMStorageAgent.cpp: > (WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent): > * inspector/front-end/DOMStorage.js: > (WebInspector.DOMStorageModel.prototype._domStorageItemsCleared): > (WebInspector.DOMStorageModel.prototype._domStorageItemRemoved): > (WebInspector.DOMStorageModel.prototype._domStorageItemAdded): > (WebInspector.DOMStorageModel.prototype._domStorageItemUpdated): > (WebInspector.DOMStorageDispatcher.prototype.domStorageItemsCleared): > (WebInspector.DOMStorageDispatcher.prototype.domStorageItemRemoved): > (WebInspector.DOMStorageDispatcher.prototype.domStorageItemAdded): > (WebInspector.DOMStorageDispatcher.prototype.domStorageItemUpdated): > * inspector/front-end/DOMStorageItemsView.js: > (WebInspector.DOMStorageItemsView): > (WebInspector.DOMStorageItemsView.prototype.wasShown): > (WebInspector.DOMStorageItemsView.prototype._domStorageItemsCleared): > (WebInspector.DOMStorageItemsView.prototype._domStorageItemRemoved): > (WebInspector.DOMStorageItemsView.prototype._domStorageItemAdded): > (WebInspector.DOMStorageItemsView.prototype._domStorageItemUpdated): > (WebInspector.DOMStorageItemsView.prototype._update): > (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): > (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked): > (WebInspector.DOMStorageItemsView.prototype._editingCallback): > (WebInspector.DOMStorageItemsView.prototype._deleteCallback): > * inspector/front-end/ResourcesPanel.js: > (WebInspector.ResourcesPanel): > (WebInspector.ResourcesPanel.prototype._showDOMStorage.get if): > (WebInspector.ResourcesPanel.prototype._showDOMStorage): > TBR=vivek.vg@samsung.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -233 lines) Patch
M Source/WebCore/inspector/Inspector.json View 3 chunks +6 lines, -30 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMStorageAgent.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M Source/WebCore/inspector/front-end/DOMStorage.js View 4 chunks +6 lines, -92 lines 0 comments Download
M Source/WebCore/inspector/front-end/DOMStorageItemsView.js View 9 chunks +11 lines, -99 lines 0 comments Download
M Source/WebCore/inspector/front-end/ResourcesPanel.js View 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eustas
7 years, 10 months ago (2013-03-12 07:49:46 UTC) #1
eustas
7 years, 10 months ago (2013-03-12 07:50:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r145495.

Powered by Google App Engine
This is Rietveld 408576698