Switch from CommandLine switch to WebPreferences to control Pepper 3D.

Switch from CommandLine switch to WebPreferences to control Pepper 3D.

This is to get us ready to dynamically enable or disable a renderer feature whenever, for example, the gpu is switched in a multiple gpu system.

BUG=332188
TEST=
R=bbudge@chromium.org, jamesr@chromium.org, joi@chromium.org, kbr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244212

[Zhenyao Mo, 2014-01-07 23:36:46]

bbudge: content/renderer/pepper
jamesr: webkit/
ken: the rest

Thank you.

[jamesr, 2014-01-07 23:43:33]

Without patching the param traits:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...
the flag will not propagate from the browser to the render process, so I don't
think this patch can actually work.  How was this tested?

[Zhenyao Mo, 2014-01-07 23:46:33]

On 2014/01/07 23:43:33, jamesr wrote:
> Without patching the param traits:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...
> the flag will not propagate from the browser to the render process, so I don't
> think this patch can actually work.  How was this tested?

Actually I have no idea how to test pepper 3d stuff, so I am hoping any try bots
would tell me what you just said.

[Zhenyao Mo, 2014-01-07 23:53:28]

joi: content/public

[Zhenyao Mo, 2014-01-07 23:56:12]

Also add alokp@: do you know if there is a way to test the code path this CL
touched? i.e., how to test if pepper 3d is unavailable if we blacklist webgl or
pass in --disable-pepper-3d?

[Ken Russell (switch to Gerrit), 2014-01-08 03:49:37]

On 2014/01/07 23:56:12, Zhenyao Mo wrote:
> Also add alokp@: do you know if there is a way to test the code path this CL
> touched? i.e., how to test if pepper 3d is unavailable if we blacklist webgl
or
> pass in --disable-pepper-3d?

+a couple of NaCl team members

Try one of the apps in the Chrome Web Store which requires Native Client and 3D,
like Angry Bots:
https://chrome.google.com/webstore/detail/angrybots/ibdomdppnicebcgjhcjfchbon...

Disabling Pepper 3D should break the app. If it doesn't after your patch,
there's been a regression.

There should ideally also be a NaCl or Pepper test which would catch this -- and
in fact it does look like your first patch failed some related tests in
linux_swarm_triggered.

[Zhenyao Mo, 2014-01-08 23:28:42]

Testing wise: I manually tried the Angry Bots with this CL and without this CL. 
chromium's behavior didn't change.  So when I launch chromium without any extra
commandline switch, I can install and run the app.  If I run chromium with
--disable-pepper-3d or put a blacklist entry to disable webgl, then it fails to
run the app.

And I do think the linux_swarm_triggered tests caught the bug in the first CL.

Please review.

[Ken Russell (switch to Gerrit), 2014-01-08 23:47:35]

LGTM

FYI, I fixed a couple of typos in the CL description.

[bbudge, 2014-01-09 01:27:54]

content/renderer/pepper LGTM

[Zhenyao Mo, 2014-01-09 20:01:06]

jamesr, joi: ping

[jamesr, 2014-01-09 20:42:36]

lgtm

[Jói, 2014-01-10 11:19:56]

//content/public LGTM

[Zhenyao Mo, 2014-01-10 18:59:25]

Committed patchset #2 manually as r244212 (presubmit successful).