chrome/browser/notifications/persistent_notification_delegate.cc - Issue 1269923003: Plumb notification action index for desktop SW notificationclick

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/persistent_notification_delegate.cc

Issue 1269923003: Plumb notification action index for desktop SW notificationclick (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@actions

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/persistent_notification_delegate.h ('k') | chrome/browser/notifications/platform_notification_service_impl.h » ('j') | content/renderer/service_worker/service_worker_context_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/persistent_notification_delegate.cc

diff --git a/chrome/browser/notifications/persistent_notification_delegate.cc b/chrome/browser/notifications/persistent_notification_delegate.cc

index dba99c7d0f48a3411cc262e735a4a78de0ee1384..212a6d84cb2a56e30c39e1984f56f93acf5a75c0 100644

--- a/chrome/browser/notifications/persistent_notification_delegate.cc

+++ b/chrome/browser/notifications/persistent_notification_delegate.cc

@@ -33,7 +33,16 @@ void PersistentNotificationDelegate::Click() {

PlatformNotificationServiceImpl::GetInstance()->OnPersistentNotificationClick(

browser_context_,

persistent_notification_id_,

- origin_);

+ origin_,

+ -1 /* action_index */);

+void PersistentNotificationDelegate::ButtonClick(int button_index) {

+ PlatformNotificationServiceImpl::GetInstance()->OnPersistentNotificationClick(

+ browser_context_,

+ persistent_notification_id_,

+ origin_,

+ button_index);

}

std::string PersistentNotificationDelegate::id() const {