Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/compiler/x87/code-generator-x87.cc

Issue 1269913002: [turbofan] Simplifying handling of callee-cleanup stack area. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | test/cctest/compiler/test-linkage.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/compiler/code-generator-impl.h" 7 #include "src/compiler/code-generator-impl.h"
8 #include "src/compiler/gap-resolver.h" 8 #include "src/compiler/gap-resolver.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/scopes.h" 10 #include "src/scopes.h"
(...skipping 1579 matching lines...) Expand 10 before | Expand all | Expand 10 after
1590 __ ret(0); 1590 __ ret(0);
1591 } 1591 }
1592 } else if (descriptor->IsJSFunctionCall() || needs_frame_) { 1592 } else if (descriptor->IsJSFunctionCall() || needs_frame_) {
1593 // Canonicalize JSFunction return sites for now. 1593 // Canonicalize JSFunction return sites for now.
1594 if (return_label_.is_bound()) { 1594 if (return_label_.is_bound()) {
1595 __ jmp(&return_label_); 1595 __ jmp(&return_label_);
1596 } else { 1596 } else {
1597 __ bind(&return_label_); 1597 __ bind(&return_label_);
1598 __ mov(esp, ebp); // Move stack pointer back to frame pointer. 1598 __ mov(esp, ebp); // Move stack pointer back to frame pointer.
1599 __ pop(ebp); // Pop caller's frame pointer. 1599 __ pop(ebp); // Pop caller's frame pointer.
1600 int pop_count = descriptor->IsJSFunctionCall() 1600 int pop_count = static_cast<int>(descriptor->StackParameterCount());
1601 ? static_cast<int>(descriptor->JSParameterCount())
1602 : (info()->IsStub()
1603 ? info()->code_stub()->GetStackParameterCount()
1604 : 0);
1605 if (pop_count == 0) { 1601 if (pop_count == 0) {
1606 __ ret(0); 1602 __ ret(0);
1607 } else { 1603 } else {
1608 __ Ret(pop_count * kPointerSize, ebx); 1604 __ Ret(pop_count * kPointerSize, ebx);
1609 } 1605 }
1610 } 1606 }
1611 } else { 1607 } else {
1612 __ ret(0); 1608 __ ret(0);
1613 } 1609 }
1614 } 1610 }
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
1843 __ Nop(padding_size); 1839 __ Nop(padding_size);
1844 } 1840 }
1845 } 1841 }
1846 } 1842 }
1847 1843
1848 #undef __ 1844 #undef __
1849 1845
1850 } // namespace compiler 1846 } // namespace compiler
1851 } // namespace internal 1847 } // namespace internal
1852 } // namespace v8 1848 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | test/cctest/compiler/test-linkage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698