Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269913002: [turbofan] Simplifying handling of callee-cleanup stack area. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Simplifying handling of callee-cleanup stack area. R=danno@chromium.org BUG= Committed: https://crrev.com/44bfb4b57e25e1df529624a02686e98051e03c5b Cr-Commit-Position: refs/heads/master@{#29957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -52 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/c-linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/linkage.h View 4 chunks +11 lines, -6 lines 0 comments Download
M src/compiler/linkage-impl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
PTAL. Turns out that CallDescriptor::JSParameterCount() isn't so interesting after all.
5 years, 4 months ago (2015-07-31 14:10:27 UTC) #1
danno
lgtm
5 years, 4 months ago (2015-07-31 15:16:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269913002/1
5 years, 4 months ago (2015-07-31 15:16:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 15:18:40 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 15:19:01 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/44bfb4b57e25e1df529624a02686e98051e03c5b
Cr-Commit-Position: refs/heads/master@{#29957}

Powered by Google App Engine
This is Rietveld 408576698