Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1269863004: Support mapping multiple local paths under the same url prefix. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Support mapping multiple local paths under the same url prefix. This allows setting up development servers that serve mojo apps from the output directory (native apps) and from the source tree (dart apps in edit-refresh workflow) alike. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1e0809009deb6783afe4997df2b5c0485583c071

Patch Set 1 #

Patch Set 2 : Fix typos in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -33 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/devtools/common/devtoolslib/http_server.py View 3 chunks +29 lines, -23 lines 0 comments Download
M mojo/devtools/common/devtoolslib/http_server_unittest.py View 1 2 chunks +47 lines, -3 lines 0 comments Download
M mojo/devtools/common/devtoolslib/linux_shell.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/devtools/common/devtoolslib/shell.py View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-08-04 14:41:07 UTC) #1
qsr
lgtm
5 years, 4 months ago (2015-08-04 14:44:10 UTC) #2
ppi
5 years, 4 months ago (2015-08-04 14:46:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1e0809009deb6783afe4997df2b5c0485583c071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698