Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: webrtc/p2p/base/transportchannelimpl.h

Issue 1269843005: Added DtlsCertificate, a ref counted object owning an SSLIdentity (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Merge with master Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/transportchannelimpl.h
diff --git a/webrtc/p2p/base/transportchannelimpl.h b/webrtc/p2p/base/transportchannelimpl.h
index 705550b52a846c263a30f93ab55148eb49424c26..d6cbb955732b9ff221ec38f170be1107b1e01f43 100644
--- a/webrtc/p2p/base/transportchannelimpl.h
+++ b/webrtc/p2p/base/transportchannelimpl.h
@@ -12,6 +12,7 @@
#define WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
#include <string>
+
#include "webrtc/p2p/base/transport.h"
#include "webrtc/p2p/base/transportchannel.h"
@@ -76,13 +77,11 @@ class TransportChannelImpl : public TransportChannel {
virtual void OnCandidate(const Candidate& candidate) = 0;
// DTLS methods
- // Set DTLS local identity. The identity object is not copied, but the caller
- // retains ownership and must delete it after this TransportChannelImpl is
- // destroyed.
- // TODO(bemasc): Fix the ownership semantics of this method.
- virtual bool SetLocalIdentity(rtc::SSLIdentity* identity) = 0;
+ // Set DTLS local certificate.
+ virtual bool SetLocalCertificate(
+ const rtc::scoped_refptr<webrtc::DtlsCertificate>& certificate) = 0;
- // Set DTLS Remote fingerprint. Must be after local identity set.
+ // Set DTLS Remote fingerprint. Must be after local certificate set.
virtual bool SetRemoteFingerprint(const std::string& digest_alg,
const uint8* digest,
size_t digest_len) = 0;

Powered by Google App Engine
This is Rietveld 408576698