talk/app/webrtc/statscollector.cc - Issue 1269843005: Added DtlsCertificate, a ref counted object owning an SSLIdentity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/statscollector.cc

Issue 1269843005: Added DtlsCertificate, a ref counted object owning an SSLIdentity (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Merge with master Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/statscollector.cc

diff --git a/talk/app/webrtc/statscollector.cc b/talk/app/webrtc/statscollector.cc

index ad64639eb93a18f04295499712163f49331080af..dac312a90b8a5190865eae903f2040af37b5213c 100644

--- a/talk/app/webrtc/statscollector.cc

+++ b/talk/app/webrtc/statscollector.cc

@@ -700,9 +700,10 @@ void StatsCollector::ExtractSessionInfo() {

cricket::Transport* transport =

session_->GetTransport(transport_iter.second.content_name);

- rtc::scoped_ptr<rtc::SSLIdentity> identity;

- if (transport && transport->GetIdentity(identity.accept())) {

- StatsReport* r = AddCertificateReports(&(identity->certificate()));

+ rtc::scoped_refptr<webrtc::DtlsCertificate> dtlscert;

tommi (sloooow) - chröme 2015/08/18 14:49:35 nit: dtls_cert

+ if (transport && transport->GetCertificate(&dtlscert)) {

+ StatsReport* r = AddCertificateReports(

+ &(dtlscert->identity()->certificate()));

if (r)

local_cert_report_id = r->id();

}

« talk/app/webrtc/proxy.h ('K') | « talk/app/webrtc/proxy.h ('k') | talk/app/webrtc/statscollector_unittest.cc » ('j') | talk/app/webrtc/webrtcsession.h » ('J')