Issue 126983002: QUIC Cleanup to remove pending_packets from QuicSentPacketManager and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126983002: QUIC Cleanup to remove pending_packets from QuicSentPacketManager and (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)

Modified:
6 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

QUIC Cleanup to remove pending_packets from QuicSentPacketManager and use a flag in unacked_packets_. Merge internal change: 59015729 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -161 lines)			Patch
M	net/quic/quic_sent_packet_manager.h	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	27 chunks	+146 lines, -129 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	5 chunks	+4 lines, -19 lines	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Hi Ryan and Ian, chromium doesn't have FindOrNull FindOrDie. Used find() instead (as we were ...

6 years, 11 months ago (2014-01-07 23:27:55 UTC) #2

Ian Swett

On 2014/01/07 23:27:55, ramant wrote: > Hi Ryan and Ian, > chromium doesn't have FindOrNull ...

6 years, 11 months ago (2014-01-07 23:30:10 UTC) #3

lgtm

Expand Messages | Collapse Messages