Chromium Code Reviews

Issue 1269813006: [Interpreter] Remove unnecessary const specifiers on scalar types. (Closed)

Created:
5 years, 4 months ago by oth
Modified:
5 years, 4 months ago
Reviewers:
titzer, rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove unnecessary const specifiers on scalar types. BUG=v8:4280 LOG=N Committed: https://crrev.com/e6e3c6a840035588811f0a208cbe6f9c0f3d53cc Cr-Commit-Position: refs/heads/master@{#29961}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+10 lines, -10 lines)
M src/interpreter/bytecodes.h View 1 chunk +5 lines, -5 lines 0 comments
M src/interpreter/bytecodes.cc View 2 chunks +5 lines, -5 lines 0 comments

Messages

Total messages: 12 (4 generated)
oth
PTAL, thanks!
5 years, 4 months ago (2015-07-31 10:01:43 UTC) #2
rmcilroy
On 2015/07/31 10:01:43, oth wrote: > PTAL, thanks! lgtm, thanks!
5 years, 4 months ago (2015-07-31 10:35:21 UTC) #3
titzer
lgtm
5 years, 4 months ago (2015-07-31 11:10:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269813006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269813006/1
5 years, 4 months ago (2015-08-01 06:55:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4613)
5 years, 4 months ago (2015-08-01 06:57:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269813006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269813006/1
5 years, 4 months ago (2015-08-01 07:23:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-01 07:25:28 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-01 07:25:39 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e6e3c6a840035588811f0a208cbe6f9c0f3d53cc
Cr-Commit-Position: refs/heads/master@{#29961}

Powered by Google App Engine