content/browser/web_contents/web_contents_impl.h - Issue 1269813002: Add a NavigationThrottle to the public content/ interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1269813002: Add a NavigationThrottle to the public content/ interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-api

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 95eb49a0d0f4e24d12ad23a0eecd02a24dd5f28c..92b8839f3858db8941c46ad3af614836366efbb5 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -513,6 +513,7 @@ class CONTENT_EXPORT WebContentsImpl

void DidRedirectNavigation(NavigationHandle* navigation_handle) override;

void DidCommitNavigation(NavigationHandle* navigation_handle) override;

void DidFinishNavigation(NavigationHandle* navigation_handle) override;

+ void AddNavigationThrottles(NavigationHandle* navigation_handle) override;

nasko 2015/08/31 23:25:15 Might be worthwhile adding a "for_main_frame_only"

clamy 2015/09/03 15:30:52 I'm not sure the parameter is necessary, since the

nasko 2015/09/04 23:36:49 Acknowledged.

void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,

const GURL& validated_url,

bool is_error_page,