Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 1269813002: Add a NavigationThrottle to the public content/ interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-api
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.h
diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h
index a1530b4e159bf4d38fe4a0b09ada2f779174285f..02fd90017e8258489a287a45802d278f8241a816 100644
--- a/content/browser/frame_host/navigation_request.h
+++ b/content/browser/frame_host/navigation_request.h
@@ -149,9 +149,9 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {
const NavigationEntryImpl* navitation_entry);
// NavigationURLLoaderDelegate implementation.
- void OnRequestRedirected(
- const net::RedirectInfo& redirect_info,
- const scoped_refptr<ResourceResponse>& response) override;
+ void OnRequestRedirected(const net::RedirectInfo& redirect_info,
+ const scoped_refptr<ResourceResponse>& response,
+ bool is_external_protocol) override;
void OnResponseStarted(const scoped_refptr<ResourceResponse>& response,
scoped_ptr<StreamHandle> body) override;
void OnRequestFailed(bool has_stale_copy_in_cache, int net_error) override;
@@ -164,8 +164,10 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {
// Note: When the navigation is ready to commit, the url in |common_params|
// will be set to the final navigation url, obtained after following all
// redirects.
+ // Note: |common_params_| and |begin_params_| are not const as they can be
+ // modified during redirects.
CommonNavigationParams common_params_;
- const BeginNavigationParams begin_params_;
+ BeginNavigationParams begin_params_;
const RequestNavigationParams request_params_;
const bool browser_initiated_;

Powered by Google App Engine
This is Rietveld 408576698