content/browser/loader/navigation_url_loader_unittest.cc - Issue 1269813002: Add a NavigationThrottle to the public content/ interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_unittest.cc

Issue 1269813002: Add a NavigationThrottle to the public content/ interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-api

Patch Set: Addressed comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/navigation_resource_handler.cc ('K') | « content/browser/loader/navigation_url_loader_impl_core.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_unittest.cc

diff --git a/content/browser/loader/navigation_url_loader_unittest.cc b/content/browser/loader/navigation_url_loader_unittest.cc

index df5e9d6aeacc7b935c4d3c6eba5771e2c6257fd7..c3fc6db64cb2bb5e1992242399c86d742c19980f 100644

--- a/content/browser/loader/navigation_url_loader_unittest.cc

+++ b/content/browser/loader/navigation_url_loader_unittest.cc

@@ -97,9 +97,9 @@ class TestNavigationURLLoaderDelegate : public NavigationURLLoaderDelegate {

}

// NavigationURLLoaderDelegate implementation.

- void OnRequestRedirected(

- const net::RedirectInfo& redirect_info,

- const scoped_refptr<ResourceResponse>& response) override {

+ void OnRequestRedirected(const net::RedirectInfo& redirect_info,

+ const scoped_refptr<ResourceResponse>& response,

+ bool is_external_protocol) override {

redirect_info_ = redirect_info;

redirect_response_ = response;

ASSERT_TRUE(request_redirected_);