Add a NavigationThrottle to the public content/ interface

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <utility>
@@ skipping 80 matching lines @@
 class BrowserPluginGuestDelegate;
 class BrowserPpapiHost;
 class BrowserURLHandler;
 class ClientCertificateDelegate;
 class DevToolsManagerDelegate;
 class ExternalVideoSurfaceContainer;
 class LocationProvider;
 class MediaObserver;
 class NavigatorConnectContext;
 class NavigatorConnectServiceFactory;
+class NavigationHandle;
 class PlatformNotificationService;
 class PresentationServiceDelegate;
 class QuotaPermissionContext;
 class RenderFrameHost;
 class RenderProcessHost;
 class RenderViewHost;
 class ResourceContext;
 class ServiceRegistry;
 class SiteInstance;
 class SpeechRecognitionManagerDelegate;
@@ skipping 534 matching lines @@
   // Allows programmatic opening of a new tab/window without going through
   // another WebContents. For example, from a Worker. |callback| will be
   // invoked with the appropriate WebContents* when available.
   virtual void OpenURL(BrowserContext* browser_context,
                        const OpenURLParams& params,
                        const base::Callback<void(WebContents*)>& callback);
 
   // Allows the embedder to record |metric| for a specific |url|.
   virtual void RecordURLMetric(const std::string& metric, const GURL& url) {}
 
+  // Allows the embedder to register NavigationThrottles for a navigation.

[nasko, 2015/08/31 23:25:15]

nit: s/NavigationThrottles/one or more NavigationThrottle/

[clamy, 2015/09/03 15:30:52]

Done.

+  // NavigationThrottles are used to control the flow of a navigation on the UI

[nasko, 2015/08/31 23:25:15]

nit: Singular NavigationThrottle.

[clamy, 2015/09/03 15:30:52]

Done.

+  // thread. The embedder is guaranteed that the throttles will be executed in
+  // the order they were registered.

[nasko, 2015/08/31 23:25:15]

The order is guaranteed for each embedder, but embedders order isn't, right?

[Avi (use Gerrit), 2015/09/01 16:38:47]

What do you mean by that question? There is always exactly one embedder.

+  virtual void AddNavigationThrottles(NavigationHandle* navigation_handle,
+                                      WebContents* web_contents) {}

[davidben, 2015/09/01 21:55:18]

It's a little odd that this API is called AddNavigationThrottles, but it's not
really specific to navigation throttles. It seems to just be a thing that
signals a particular point in the timeline (start of navigation or so).

[clamy, 2015/09/03 15:30:52]

Due to changes to the NavigationHandle interface, it now returns a vector of
NavigationThrottles. I think it makes more sense now.

+
   // Populates |mappings| with all files that need to be mapped before launching
   // a child process.
 #if defined(OS_ANDROID)
   virtual void GetAdditionalMappedFilesForChildProcess(
       const base::CommandLine& command_line,
       int child_process_id,
       content::FileDescriptorInfo* mappings,
       std::map<int, base::MemoryMappedFile::Region>* regions) {}
 #elif defined(OS_POSIX) && !defined(OS_MACOSX)
   virtual void GetAdditionalMappedFilesForChildProcess(
@@ skipping 23 matching lines @@
   // Allows an embedder to provide its own ExternalVideoSurfaceContainer
   // implementation.  Return nullptr to disable external surface video.
   virtual ExternalVideoSurfaceContainer*
   OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_