Add a NavigationThrottle to the public content/ interface

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/frame_tree.h"
@@ skipping 140 matching lines @@
       render_frame_host->navigation_handle()->set_is_transferring(false);
       return;
     }
 
     // This ensures that notifications about the end of the previous
     // navigation are sent before notifications about the start of the
     // new navigation.
     render_frame_host->SetNavigationHandle(scoped_ptr<NavigationHandleImpl>());
   }
 
-  render_frame_host->SetNavigationHandle(
-      NavigationHandleImpl::Create(url, is_main_frame, delegate_));
+  GURL filtered_url = url;
+  render_frame_host->GetProcess()->FilterURL(false, &filtered_url);
+  render_frame_host->SetNavigationHandle(NavigationHandleImpl::Create(
+      url, filtered_url, is_main_frame, delegate_));

[nasko, 2015/08/31 23:25:15]

Why do we need both? We never keep the two around in today's navigation logic,
do we?

[clamy, 2015/09/03 15:30:51]

We need to provide the filtered url to the throttles, and we also need to keep
the unfiltered one to do proper checks with what is sent by the renderer. In
order to filter the url, we need access to the process, which we currently can't
do from the NavigationHandle (in particular with PlzNavigate, in the current
architecture we could keep a pointer to the renderer). Hence why I'm keeping
both.

[nasko, 2015/09/04 23:36:49]

Where do we do those checks? Why can't we frontload the checks? Also, if we got
an invalid URL from a renderer, it is likely a good reason for terminating the
process.

 }
 
 void NavigatorImpl::DidFailProvisionalLoadWithError(
     RenderFrameHostImpl* render_frame_host,
     const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {
   VLOG(1) << "Failed Provisional Load: " << params.url.possibly_invalid_spec()
           << ", error_code: " << params.error_code
           << ", error_description: " << params.error_description
           << ", showing_repost_interstitial: " <<
             params.showing_repost_interstitial
@@ skipping 770 matching lines @@
       entry->set_should_replace_entry(pending_entry->should_replace_entry());
       entry->SetRedirectChain(pending_entry->GetRedirectChain());
     }
     controller_->SetPendingEntry(entry.Pass());
     if (delegate_)
       delegate_->NotifyChangedNavigationState(content::INVALIDATE_TYPE_URL);
   }
 }
 
 }  // namespace content