Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: content/public/browser/content_browser_client.h

Issue 1269813002: Add a NavigationThrottle to the public content/ interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-api
Patch Set: Addressed comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 class BrowserPluginGuestDelegate; 91 class BrowserPluginGuestDelegate;
92 class BrowserPpapiHost; 92 class BrowserPpapiHost;
93 class BrowserURLHandler; 93 class BrowserURLHandler;
94 class ClientCertificateDelegate; 94 class ClientCertificateDelegate;
95 class DevToolsManagerDelegate; 95 class DevToolsManagerDelegate;
96 class ExternalVideoSurfaceContainer; 96 class ExternalVideoSurfaceContainer;
97 class LocationProvider; 97 class LocationProvider;
98 class MediaObserver; 98 class MediaObserver;
99 class NavigatorConnectContext; 99 class NavigatorConnectContext;
100 class NavigatorConnectServiceFactory; 100 class NavigatorConnectServiceFactory;
101 class NavigationHandle;
102 class NavigationThrottle;
101 class PlatformNotificationService; 103 class PlatformNotificationService;
102 class PresentationServiceDelegate; 104 class PresentationServiceDelegate;
103 class QuotaPermissionContext; 105 class QuotaPermissionContext;
104 class RenderFrameHost; 106 class RenderFrameHost;
105 class RenderProcessHost; 107 class RenderProcessHost;
106 class RenderViewHost; 108 class RenderViewHost;
107 class ResourceContext; 109 class ResourceContext;
108 class ServiceRegistry; 110 class ServiceRegistry;
109 class SiteInstance; 111 class SiteInstance;
110 class SpeechRecognitionManagerDelegate; 112 class SpeechRecognitionManagerDelegate;
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 // Allows programmatic opening of a new tab/window without going through 647 // Allows programmatic opening of a new tab/window without going through
646 // another WebContents. For example, from a Worker. |callback| will be 648 // another WebContents. For example, from a Worker. |callback| will be
647 // invoked with the appropriate WebContents* when available. 649 // invoked with the appropriate WebContents* when available.
648 virtual void OpenURL(BrowserContext* browser_context, 650 virtual void OpenURL(BrowserContext* browser_context,
649 const OpenURLParams& params, 651 const OpenURLParams& params,
650 const base::Callback<void(WebContents*)>& callback); 652 const base::Callback<void(WebContents*)>& callback);
651 653
652 // Allows the embedder to record |metric| for a specific |url|. 654 // Allows the embedder to record |metric| for a specific |url|.
653 virtual void RecordURLMetric(const std::string& metric, const GURL& url) {} 655 virtual void RecordURLMetric(const std::string& metric, const GURL& url) {}
654 656
657 // Allows the embedder to register one or more NavigationThrottle for a
nasko 2015/09/04 23:36:49 nit: one or more implies the next word being plura
clamy 2015/09/08 16:27:19 Done.
658 // navigation. A NavigationThrottle is used to control the flow of a
659 // navigation on the UI thread. The embedder is guaranteed that the throttles
660 // will be executed in the order they were registered.
nasko 2015/09/04 23:36:49 nit: s/registered/provided/, since the embedder on
clamy 2015/09/08 16:27:19 Done.
661 // Note that the ownership of the NavigationThrottles returned will be taken
662 // by the NavigationHandle.
nasko 2015/09/04 23:36:49 This note won't be necessary if we have ScopedVect
clamy 2015/09/08 16:27:19 Done.
663 virtual std::vector<NavigationThrottle*> AddNavigationThrottles(
664 NavigationHandle* navigation_handle,
665 WebContents* web_contents);
666
655 // Populates |mappings| with all files that need to be mapped before launching 667 // Populates |mappings| with all files that need to be mapped before launching
656 // a child process. 668 // a child process.
657 #if defined(OS_ANDROID) 669 #if defined(OS_ANDROID)
658 virtual void GetAdditionalMappedFilesForChildProcess( 670 virtual void GetAdditionalMappedFilesForChildProcess(
659 const base::CommandLine& command_line, 671 const base::CommandLine& command_line,
660 int child_process_id, 672 int child_process_id,
661 content::FileDescriptorInfo* mappings, 673 content::FileDescriptorInfo* mappings,
662 std::map<int, base::MemoryMappedFile::Region>* regions) {} 674 std::map<int, base::MemoryMappedFile::Region>* regions) {}
663 #elif defined(OS_POSIX) && !defined(OS_MACOSX) 675 #elif defined(OS_POSIX) && !defined(OS_MACOSX)
664 virtual void GetAdditionalMappedFilesForChildProcess( 676 virtual void GetAdditionalMappedFilesForChildProcess(
(...skipping 23 matching lines...) Expand all
688 // Allows an embedder to provide its own ExternalVideoSurfaceContainer 700 // Allows an embedder to provide its own ExternalVideoSurfaceContainer
689 // implementation. Return nullptr to disable external surface video. 701 // implementation. Return nullptr to disable external surface video.
690 virtual ExternalVideoSurfaceContainer* 702 virtual ExternalVideoSurfaceContainer*
691 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents); 703 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
692 #endif 704 #endif
693 }; 705 };
694 706
695 } // namespace content 707 } // namespace content
696 708
697 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 709 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698