Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1269793007: Explicitly pass WebString to enableFeatureFromString() (Closed)

Created:
5 years, 4 months ago by bashi
Modified:
5 years, 4 months ago
Reviewers:
kinuko, haraken
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly pass WebString to enableFeatureFromString() We are going to replace WebString with std::string in WebRuntimeFeatures[1]. As a preparation, this CL passes WebString object to enableFeatureFromString() explicitly because we will add another enableFeatureFromString() which takes std::string, which will be ambiguous if we pass string literal. I'll revert this CL when blink side CL is landed. [1] https://codereview.chromium.org/1259763006/ BUG=501171 Committed: https://crrev.com/31ad3e6a80c367c4f8ea0a921e8f2cfe555a5fd6 Cr-Commit-Position: refs/heads/master@{#341690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/child/runtime_features.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
bashi
Kinuko-san, could you review this trivial one? I needed this CL to land https://codereview.chromium.org/1259763006/
5 years, 4 months ago (2015-08-04 00:27:30 UTC) #2
haraken
non-owner LGTM
5 years, 4 months ago (2015-08-04 00:28:28 UTC) #3
kinuko
lgtm
5 years, 4 months ago (2015-08-04 04:38:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269793007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269793007/1
5 years, 4 months ago (2015-08-04 04:41:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/88050)
5 years, 4 months ago (2015-08-04 06:16:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269793007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269793007/1
5 years, 4 months ago (2015-08-04 06:18:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 07:01:56 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 07:02:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31ad3e6a80c367c4f8ea0a921e8f2cfe555a5fd6
Cr-Commit-Position: refs/heads/master@{#341690}

Powered by Google App Engine
This is Rietveld 408576698