Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1269793005: Remove the no-longer-used chromeos::switches::kHasChromeOSKeyboard (Closed)

Created:
5 years, 4 months ago by afakhry
Modified:
5 years, 4 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the no-longer-used chromeos::switches::kHasChromeOSKeyboard The last usage of this switch was removed in this CL: https://codereview.chromium.org/1188693002/. We don't need to keep it around. BUG=501121 Committed: https://crrev.com/3920b7273eca34d1108b048f1eec3fd573b86524 Cr-Commit-Position: refs/heads/master@{#341364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
afakhry
derat@chromium.org: Could you please review this CL? Thanks!
5 years, 4 months ago (2015-07-31 01:08:03 UTC) #2
use derat at chromium.org
lgtm
5 years, 4 months ago (2015-07-31 03:50:51 UTC) #4
afakhry
On 2015/07/31 03:50:51, use derat at chromium.org wrote: > lgtm I think you need to ...
5 years, 4 months ago (2015-07-31 17:21:02 UTC) #5
Daniel Erat
lgtm ugh, sorry; i wish that chromium.org accounts didn't exist. i've given up multilogin ever ...
5 years, 4 months ago (2015-07-31 17:49:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269793005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269793005/1
5 years, 4 months ago (2015-07-31 17:55:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 18:01:05 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 18:01:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3920b7273eca34d1108b048f1eec3fd573b86524
Cr-Commit-Position: refs/heads/master@{#341364}

Powered by Google App Engine
This is Rietveld 408576698