fpdfsdk/include/javascript/JS_Runtime.h - Issue 1269783005: Don't dispose the isolate if its provided by the embedder

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fpdfsdk/include/javascript/JS_Runtime.h

Issue 1269783005: Don't dispose the isolate if its provided by the embedder (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Runtime.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_	7 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_

8 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_	8 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_

9	9

10 #include "../../../third_party/base/nonstd_unique_ptr.h"	10 #include "../../../third_party/base/nonstd_unique_ptr.h"

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61 v8::Local<v8::Context> NewJSContext();	61 v8::Local<v8::Context> NewJSContext();

62	62

63 protected:	63 protected:

64 CFX_ArrayTemplate<CJS_Context*> m_ContextArray;	64 CFX_ArrayTemplate<CJS_Context*> m_ContextArray;

65 CPDFDoc_Environment* m_pApp;	65 CPDFDoc_Environment* m_pApp;

66 CPDFSDK_Document* m_pDocument;	66 CPDFSDK_Document* m_pDocument;

67 FX_BOOL m_bBlocking;	67 FX_BOOL m_bBlocking;

68 CJS_FieldEvent* m_pFieldEventPath;	68 CJS_FieldEvent* m_pFieldEventPath;

69	69

70 v8::Isolate* m_isolate;	70 v8::Isolate* m_isolate;

	71 bool m_isolateManaged;

71 nonstd::unique_ptr<CJS_ArrayBufferAllocator> m_pArrayBufferAllocator;	72 nonstd::unique_ptr<CJS_ArrayBufferAllocator> m_pArrayBufferAllocator;

72 v8::Global<v8::Context> m_context;	73 v8::Global<v8::Context> m_context;

73 };	74 };

74	75

75 #endif // FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_	76 #endif // FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_

OLD	NEW