Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/service/net/service_url_request_context_getter.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/cloud_print/cloud_print_service_helpers_unittest.cc ('k') | extensions/browser/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/net/service_url_request_context_getter.cc
diff --git a/chrome/service/net/service_url_request_context_getter.cc b/chrome/service/net/service_url_request_context_getter.cc
index 508fdc8c03580c708287e2154b1f9d6ff8735cf2..0f11bfaf97367895c132ded7103dd27cd1c8f906 100644
--- a/chrome/service/net/service_url_request_context_getter.cc
+++ b/chrome/service/net/service_url_request_context_getter.cc
@@ -12,8 +12,8 @@
#include "base/single_thread_task_runner.h"
#include "base/strings/stringprintf.h"
#include "base/sys_info.h"
-#include "chrome/common/chrome_version_info.h"
#include "chrome/service/service_process.h"
+#include "components/version_info/version_info.h"
#include "net/proxy/proxy_config_service.h"
#include "net/proxy/proxy_service.h"
#include "net/url_request/url_request_context_builder.h"
@@ -79,14 +79,13 @@ std::string BuildOSCpuInfo() {
// Returns the default user agent.
std::string MakeUserAgentForServiceProcess() {
std::string user_agent;
- chrome::VersionInfo version_info;
std::string extra_version_info;
- if (!version_info.IsOfficialBuild())
+ if (!version_info::IsOfficialBuild())
extra_version_info = "-devel";
base::StringAppendF(&user_agent,
"Chrome Service %s(%s)%s %s ",
- version_info.Version().c_str(),
- version_info.LastChange().c_str(),
+ version_info::GetVersionNumber().c_str(),
+ version_info::GetLastChange().c_str(),
extra_version_info.c_str(),
BuildOSCpuInfo().c_str());
return user_agent;
« no previous file with comments | « chrome/service/cloud_print/cloud_print_service_helpers_unittest.cc ('k') | extensions/browser/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698