Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8313)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/service_process_util_mac.mm

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/service_process_util.cc ('k') | chrome/common/service_process_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/service_process_util_mac.mm
diff --git a/chrome/common/service_process_util_mac.mm b/chrome/common/service_process_util_mac.mm
index d6d1c3b006b9ee2d7528bbd62753fe096fbcb205..5a229eb017d404b02aa1c41205f109da0d5da9f3 100644
--- a/chrome/common/service_process_util_mac.mm
+++ b/chrome/common/service_process_util_mac.mm
@@ -26,8 +26,8 @@
#include "base/version.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
-#include "chrome/common/chrome_version_info.h"
#include "chrome/common/mac/launchd.h"
+#include "components/version_info/version_info.h"
#include "ipc/unix_domain_socket_util.h"
using ::base::FilePathWatcher;
@@ -208,8 +208,7 @@ bool CheckServiceProcessReady() {
if (!service_version.IsValid()) {
ready = false;
} else {
- chrome::VersionInfo version_info;
- Version running_version(version_info.Version());
+ Version running_version(version_info::GetVersionNumber());
if (!running_version.IsValid()) {
// Our own version is invalid. This is an error case. Pretend that we
// are out of date.
« no previous file with comments | « chrome/common/service_process_util.cc ('k') | chrome/common/service_process_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698