chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc - Issue 1269773002: Cleanup VersionInfo after componentization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/automation_unittest.cc ('k') | chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

diff --git a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

index f74ced5b29de55840f30f811416c7497595cf3d2..bedbf960c7e786bcf1a87ef262dbdbac891ea813 100644

--- a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

+++ b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

@@ -6,8 +6,8 @@

#include "base/strings/utf_string_conversions.h"

#include "base/version.h"

-#include "chrome/common/chrome_version_info.h"

#include "chrome/grit/chromium_strings.h"

+#include "components/version_info/version_info.h"

#include "extensions/common/error_utils.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest_constants.h"

@@ -39,8 +39,7 @@ bool MinimumChromeVersionChecker::Parse(Extension* extension,

return false;

}

- chrome::VersionInfo current_version_info;

- Version current_version(current_version_info.Version());

+ Version current_version(version_info::GetVersionNumber());

if (!current_version.IsValid()) {

NOTREACHED();

return false;