Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3361)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/cloud_print/cloud_print_helpers.cc

Issue 1269773002: Cleanup VersionInfo after componentization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_version_info_win.cc ('k') | chrome/common/cloud_print/cloud_print_helpers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/cloud_print/cloud_print_helpers.cc
diff --git a/chrome/common/cloud_print/cloud_print_helpers.cc b/chrome/common/cloud_print/cloud_print_helpers.cc
index ff1eaeb786fe102439d085c2157482fe7377dcc9..c2e1614735120b2b88116822ff0a9570fd7ef513 100644
--- a/chrome/common/cloud_print/cloud_print_helpers.cc
+++ b/chrome/common/cloud_print/cloud_print_helpers.cc
@@ -12,7 +12,7 @@
#include "base/strings/stringprintf.h"
#include "base/sys_info.h"
#include "base/values.h"
-#include "chrome/common/chrome_version_info.h"
+#include "chrome/common/channel_info.h"
#include "chrome/common/cloud_print/cloud_print_constants.h"
#include "net/base/mime_util.h"
#include "url/gurl.h"
@@ -25,9 +25,7 @@ namespace {
// required by cloud print server.
PrinterTags PreparePrinterTags(const PrinterTags& printer_tags) {
PrinterTags printer_tags_out = printer_tags;
- chrome::VersionInfo version_info;
- printer_tags_out[kChromeVersionTagName] =
- version_info.CreateVersionString();
+ printer_tags_out[kChromeVersionTagName] = chrome::GetVersionString();
printer_tags_out[kSystemNameTagName] =
base::SysInfo::OperatingSystemName();
printer_tags_out[kSystemVersionTagName] =
« no previous file with comments | « chrome/common/chrome_version_info_win.cc ('k') | chrome/common/cloud_print/cloud_print_helpers_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698